From: Matthew Wilcox <willy@infradead.org>
To: Wang Yugui <wangyugui@e16-tech.com>
Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@infradead.org>,
"Darrick J . Wong" <djwong@kernel.org>
Subject: Re: [PATCH 1/3] filemap: Allow __filemap_get_folio to allocate large folios
Date: Sun, 21 May 2023 02:56:33 +0100 [thread overview]
Message-ID: <ZGl6UZ0a+fIAPmn5@casper.infradead.org> (raw)
In-Reply-To: <20230521090235.4860.409509F4@e16-tech.com>
On Sun, May 21, 2023 at 09:02:36AM +0800, Wang Yugui wrote:
> > +static inline unsigned fgp_order(size_t size)
> > +{
> > + unsigned int shift = ilog2(size);
> > +
> > + if (shift <= PAGE_SHIFT)
> > + return 0;
> > + return (shift - PAGE_SHIFT) << 26;
>
> int overflow will happen when size > 0.5M(2**19)?
I don't see it?
size == 1 << 20;
shift = 20;
return (20 - 12) << 26;
Looks like about 1 << 29 to me.
next prev parent reply other threads:[~2023-05-21 1:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-20 16:36 [PATCH 0/3] Create large folios in iomap buffered write path Matthew Wilcox (Oracle)
2023-05-20 16:36 ` [PATCH 1/3] filemap: Allow __filemap_get_folio to allocate large folios Matthew Wilcox (Oracle)
2023-05-21 1:02 ` Wang Yugui
2023-05-21 1:56 ` Matthew Wilcox [this message]
2023-05-21 2:04 ` Wang Yugui
2023-05-21 3:39 ` Matthew Wilcox
2023-05-21 2:13 ` Dave Chinner
2023-05-21 3:38 ` Matthew Wilcox
2023-05-23 5:59 ` Christoph Hellwig
2023-05-23 12:17 ` Matthew Wilcox
2023-05-20 16:36 ` [PATCH 2/3] iomap: Create large folios in the buffered write path Matthew Wilcox (Oracle)
2023-05-20 16:36 ` [PATCH 3/3] iomap: Copy larger chunks from userspace Matthew Wilcox (Oracle)
2023-05-20 19:11 ` kernel test robot
2023-05-20 19:25 ` kernel test robot
2023-05-21 0:49 ` [PATCH 0/3] Create large folios in iomap buffered write path Wang Yugui
2023-05-21 0:59 ` Matthew Wilcox
2023-05-21 1:38 ` Wang Yugui
2023-05-21 2:49 ` Dave Chinner
2023-05-21 11:40 ` Wang Yugui
2023-05-31 4:34 ` Wang Yugui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGl6UZ0a+fIAPmn5@casper.infradead.org \
--to=willy@infradead.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=wangyugui@e16-tech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).