From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26B32C7EE23 for ; Tue, 23 May 2023 13:37:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236316AbjEWNhY (ORCPT ); Tue, 23 May 2023 09:37:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232554AbjEWNhX (ORCPT ); Tue, 23 May 2023 09:37:23 -0400 X-Greylist: delayed 180 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 23 May 2023 06:37:17 PDT Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C42D2118 for ; Tue, 23 May 2023 06:37:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Kw4TxwgeOi/rgp7Fv4+clTuRK+8n6ArCGyls+zA2GjQ=; b=HN7yEl2WJmTwshKzFofUhypEzx upP9zsmNiDzNoxT7vRn+3LsT4nR+6BQDei6If4c2ybkmfAiBuTrCApsiQxSd0XCmDFjRGD/X9Z8PK p76yKGDZNlh2j28FxLDSCiJWmgNyWS1Bme3zTF2qmqJZ6h+4LtLvEa9ZIGjs8WFy50+z/tdjT1xTM S+PWq92h9y8DPIjZn13jNHOKHKi6NpoxBlNDyCVwGMCtTmZLK00oOEtB+hwRGDH5oUUm2Esf48Ly0 QsVpBR4lLjFzWi764Qp3xYK4wGVDZMYewvveWhoFppuwJfC1KGU/Zt2ZGlFVcygsNM+i8hLmKGFs3 khj2rAGA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1q1SCQ-00AG4x-QM; Tue, 23 May 2023 13:37:14 +0000 Date: Tue, 23 May 2023 14:37:14 +0100 From: Matthew Wilcox To: Andreas Gruenbacher Cc: linux-fsdevel@vger.kernel.org, Andrew Morton , Bob Peterson , cluster-devel@redhat.com, Hannes Reinecke , Luis Chamberlain Subject: Re: [PATCH 5/6] gfs2: Support ludicrously large folios in gfs2_trans_add_databufs() Message-ID: References: <20230517032442.1135379-1-willy@infradead.org> <20230517032442.1135379-6-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, May 23, 2023 at 02:46:07PM +0200, Andreas Gruenbacher wrote: > > void gfs2_trans_add_databufs(struct gfs2_inode *ip, struct folio *folio, > > - unsigned int from, unsigned int len) > > + size_t from, size_t len) > > { > > struct buffer_head *head = folio_buffers(folio); > > unsigned int bsize = head->b_size; > > This only makes sense if the to, start, and end variables in > gfs2_trans_add_databufs() are changed from unsigned int to size_t as > well. The history of this patch is that I started doing conversions from page -> folio in gfs2, then you came out with a very similar series. This patch is the remainder after rebasing my patches on yours. So we can either drop this patch or just apply it. I wasn't making a concerted effort to make gfs2 support 4GB+ sized folios, it's just part of the conversion that I do. > > extern void gfs2_trans_add_databufs(struct gfs2_inode *ip, struct folio *folio, > > - unsigned int from, unsigned int len); > > + size_t from, size_t len);