From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2860C7EE33 for ; Mon, 5 Jun 2023 07:13:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230430AbjFEHNt (ORCPT ); Mon, 5 Jun 2023 03:13:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229976AbjFEHNl (ORCPT ); Mon, 5 Jun 2023 03:13:41 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 757AEE78; Mon, 5 Jun 2023 00:13:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=24NtoYhKvZ49mRzAxCPfQuGcFIxKUXmj4oYlBfA1+No=; b=HmTaFC7HfXqOAdPtQr2UennWQN wwqjqQyMVixk17VL+BUOwDd6w6dwkss7xDDAMuG/mx8cZY7xDZu3F7REOnh+VJiviA7vUZQf0WAKO N4lZHeg6BVOqRX/a8HGOP/o23sZu29LYTG07bvJ+IYmzPyJQIyHBKW+R8tioNdiRnVHkna/n1CUOx Py15OAhy3VRhqqCqI8gTG/rg1eWiwtsYG7Zci7/nC0+X85jmwZpKPtuPQcepYdByPva7tsEAZbTJl TtF/UVopNdpvsIQjbqj/cfODEjvwdH/XJltP9Gm1UFv3qaSzUoxDOh7+4zRgR7wlAa89jjze1vvvz jOKA60xQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q64P0-00EVwR-0p; Mon, 05 Jun 2023 07:13:18 +0000 Date: Mon, 5 Jun 2023 00:13:18 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, Wang Yugui , Dave Chinner , Christoph Hellwig , "Darrick J . Wong" Subject: Re: [PATCH v2 3/7] iomap: Remove unnecessary test from iomap_release_folio() Message-ID: References: <20230602222445.2284892-1-willy@infradead.org> <20230602222445.2284892-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230602222445.2284892-4-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org > - * dirty folios to ->release_folio() via shrink_active_list(); > - * skip those here. > + * If the folio is dirty, we refuse to release our metadata because > + * it may be partially dirty (FIXME, add a test for that). I'd prefer not to add this FIXME as we're fine without the per-block dirty tracking. Otherwise looks good: Reviewed-by: Christoph Hellwig