From: Matthew Wilcox <willy@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: DIO hangs in 6.4.0-rc2
Date: Mon, 5 Jun 2023 17:16:40 +0100 [thread overview]
Message-ID: <ZH4KaEtLS1bdSl1c@casper.infradead.org> (raw)
In-Reply-To: <ZGP/H1UQgMYemYP1@dread.disaster.area>
On Wed, May 17, 2023 at 08:09:35AM +1000, Dave Chinner wrote:
> On Tue, May 16, 2023 at 01:28:00PM +0100, Matthew Wilcox wrote:
> > Plain 6.4.0-rc2 with a relatively minor change to the futex code that
> > I cannot believe was in any way responsible for this.
> >
> > kworkers blocked all over the place. Some on XFS_ILOCK_EXCL. Some on
> > xfs_buf_lock. One in xfs_btree_split() calling wait_for_completion.
> >
> > This was an overnight test run that is now dead, so I can't get any
> > more info from the locked up kernel. I have the vmlinux if some
> > decoding of offsets is useful.
>
> This is likely the same AGF try-lock bug that was discovered in this
> thread:
>
> https://lore.kernel.org/linux-xfs/202305090905.aff4e0e6-oliver.sang@intel.com/
>
> The fact that the try-lock was ignored means that out of order AGF
> locking can be attempted, and the try-lock prevents deadlocks from
> occurring.
>
> Can you try the patch below - I was going to send it for review
> anyway this morning so it can't hurt to see if it also fixes this
> issue.
I still have this patch in my tree and it's not in rc5. Was this
problem fixed some other way, or does it still need to land upstream?
I don't see any changes to XFS since May 11th's pull request.
next prev parent reply other threads:[~2023-06-05 16:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 12:28 DIO hangs in 6.4.0-rc2 Matthew Wilcox
2023-05-16 14:53 ` Darrick J. Wong
2023-05-16 16:41 ` Matthew Wilcox
2023-05-16 22:09 ` Dave Chinner
2023-06-05 16:16 ` Matthew Wilcox [this message]
2023-06-05 17:18 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH4KaEtLS1bdSl1c@casper.infradead.org \
--to=willy@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).