From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13647C77B73 for ; Mon, 5 Jun 2023 21:26:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229790AbjFEV0w (ORCPT ); Mon, 5 Jun 2023 17:26:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232757AbjFEV0u (ORCPT ); Mon, 5 Jun 2023 17:26:50 -0400 Received: from out-27.mta1.migadu.com (out-27.mta1.migadu.com [95.215.58.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 214BB100 for ; Mon, 5 Jun 2023 14:26:49 -0700 (PDT) Date: Mon, 5 Jun 2023 17:26:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1686000408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wnph7+oPyMmNyxdAR2lSsW9n2332H95DQGe3lGJ+RnM=; b=wwd5yLEgvSH4d+5xWJ6tolwo006zpdwkSJPNKLhPDVlmDucLbB43zlTx4L3qDNrxG2EuXQ 3uiAAV5lhacpa4y7Tu1zknaaEHIixORHvG/LZeJ0X89Q+f3vXAM6MfzR01MFNjROJmYhzI 3jTaKKS6JK/JJk/69GvKgK3Oow939nU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Jens Axboe Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 0/7] block layer patches for bcachefs Message-ID: References: <20230525214822.2725616-1-kent.overstreet@linux.dev> <8e874109-db4a-82e3-4020-0596eeabbadf@kernel.dk> <2a56b6d4-5f24-9738-ec83-cefb20998c8c@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Jun 05, 2023 at 10:49:37AM -0600, Jens Axboe wrote: > On 6/4/23 5:38?PM, Kent Overstreet wrote: > > On Tue, May 30, 2023 at 10:50:55AM -0600, Jens Axboe wrote: > >> Sorry typo, I meant text. Just checked stack and it looks identical, but > >> things like blk-map grows ~6% more text, and bio ~3%. Didn't check all > >> of them, but at least those two are consistent across x86-64 and > >> aarch64. Ditto on the data front. Need to take a closer look at where > >> exactly that is coming from, and what that looks like. > > > > A good chunk of that is because I added warnings and assertions for > > e.g. running past the end of the bvec array. These bugs are rare and > > shouldn't happen with normal iterator usage (e.g. the bio_for_each_* > > macros), but I'd like to keep them as a debug mode thing. > > > > But we don't yet have CONFIG_BLOCK_DEBUG - perhaps we should. > > Let's split those out then, especially as we don't have a BLOCK_DEBUG > option right now. Already did that; there's a patch in the branch that adds CONFIG_BLK_DEBUG with the new assertions. > Cn you resend just the iterator changes in their current form? The > various re-exports are a separate discussion, I think we should focus on > the iterator bits first. They're up in that branch with the iterator changes first now; I'll mail them out too.