From: Christoph Hellwig <hch@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
David Hildenbrand <david@redhat.com>,
Jens Axboe <axboe@kernel.dk>, Al Viro <viro@zeniv.linux.org.uk>,
Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
Jeff Layton <jlayton@kernel.org>,
Jason Gunthorpe <jgg@nvidia.com>,
Logan Gunthorpe <logang@deltatee.com>,
Hillf Danton <hdanton@sina.com>,
Christian Brauner <brauner@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC PATCH v2 2/3] mm: Provide a function to get an additional pin on a page
Date: Fri, 26 May 2023 01:20:18 -0700 [thread overview]
Message-ID: <ZHBrwrRiY4/WTuYe@infradead.org> (raw)
In-Reply-To: <20230525223953.225496-3-dhowells@redhat.com>
On Thu, May 25, 2023 at 11:39:52PM +0100, David Howells wrote:
> +/**
> + * page_get_additional_pin - Try to get an additional pin on a pinned page
> + * @page: The page to be pinned
> + *
> + * Get an additional pin on a page we already have a pin on. Makes no change
> + * if the page is the zero_page.
> + */
> +void page_get_additional_pin(struct page *page)
page_get_additional_pin seems like an odd name, mixing the get and
pin terminologies. What about repin_page? Or move to a folio interface
from the start can call it folio_repin?
next prev parent reply other threads:[~2023-05-26 8:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 22:39 [RFC PATCH v2 0/3] block: Make old dio use iov_iter_extract_pages() and page pinning David Howells
2023-05-25 22:39 ` [RFC PATCH v2 1/3] mm: Don't pin ZERO_PAGE in pin_user_pages() David Howells
2023-05-26 8:10 ` Lorenzo Stoakes
2023-05-26 8:17 ` Christoph Hellwig
2023-05-26 8:22 ` Christoph Hellwig
2023-05-26 8:27 ` Lorenzo Stoakes
2023-05-26 8:29 ` David Howells
2023-05-26 8:43 ` David Howells
2023-05-26 8:58 ` Lorenzo Stoakes
2023-05-26 9:15 ` David Howells
2023-05-26 9:23 ` Lorenzo Stoakes
2023-05-26 9:24 ` David Hildenbrand
2023-05-25 22:39 ` [RFC PATCH v2 2/3] mm: Provide a function to get an additional pin on a page David Howells
2023-05-26 2:29 ` Linus Torvalds
2023-05-26 5:50 ` David Howells
2023-05-26 8:20 ` Christoph Hellwig [this message]
2023-05-26 8:31 ` David Howells
2023-05-25 22:39 ` [RFC PATCH v2 3/3] block: Use iov_iter_extract_pages() and page pinning in direct-io.c David Howells
2023-05-26 8:26 ` Christoph Hellwig
2023-05-26 8:33 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHBrwrRiY4/WTuYe@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=david@redhat.com \
--cc=dhowells@redhat.com \
--cc=hdanton@sina.com \
--cc=jack@suse.cz \
--cc=jgg@nvidia.com \
--cc=jlayton@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).