From: Kent Overstreet <kent.overstreet@linux.dev>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: linux-bcachefs@vger.kernel.org, dm-devel@redhat.com,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] bcachefs: fix NULL pointer dereference in try_alloc_bucket
Date: Thu, 1 Jun 2023 13:53:51 -0400 [thread overview]
Message-ID: <ZHjbL1o1KZt1385/@moria.home.lan> (raw)
In-Reply-To: <alpine.LRH.2.21.2305300803220.12797@file01.intranet.prod.int.rdu2.redhat.com>
On Tue, May 30, 2023 at 08:15:41AM -0400, Mikulas Patocka wrote:
>
>
> On Mon, 29 May 2023, Mikulas Patocka wrote:
>
> > The oops happens in set_btree_iter_dontneed and it is caused by the fact
> > that iter->path is NULL. The code in try_alloc_bucket is buggy because it
> > sets "struct btree_iter iter = { NULL };" and then jumps to the "err"
> > label that tries to dereference values in "iter".
>
> Here I'm sending a patch for it.
>
>
>
> + set_btree_iter_dontneed(&iter);
> bch2_trans_iter_exit(trans, &iter);
I need to look at this code a bit more, perhaps we'll want to move the
check into set_btree_iter_dontneed(), since iter_exit() is safe to call
on an uninitialized-but-zeroed iterator
prev parent reply other threads:[~2023-06-01 17:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 12:15 [PATCH] bcachefs: fix NULL pointer dereference in try_alloc_bucket Mikulas Patocka
2023-06-01 17:53 ` Kent Overstreet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHjbL1o1KZt1385/@moria.home.lan \
--to=kent.overstreet@linux.dev \
--cc=dm-devel@redhat.com \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).