From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D86DC7EE2E for ; Mon, 12 Jun 2023 18:58:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237569AbjFLS6M (ORCPT ); Mon, 12 Jun 2023 14:58:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236888AbjFLS6K (ORCPT ); Mon, 12 Jun 2023 14:58:10 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2FDFAD for ; Mon, 12 Jun 2023 11:57:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686596243; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZmIquouHkn7x7g5U3IKxu0y2ezu2hrVL9nMe9oPXqp4=; b=LcDgf3QMX/cgLo7n59BV2jOHkdIsDpMxPceWbq2YfaG7bKB02NeKkomZ8Ed9j2S3x7FXvC FynsagUJq4/f7FXObYYtXA/+jCq64XPF6pEzE3RbQekNeQC3BL8VLIyIuDjvxND9bxaQ1P WcmV7Dhw/a1YWRom6jfblJf+/KajpeY= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-549-jdgf5hFAOmqYb1elqX_WFA-1; Mon, 12 Jun 2023 14:57:21 -0400 X-MC-Unique: jdgf5hFAOmqYb1elqX_WFA-1 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-3f9e7a1caf2so6340491cf.0 for ; Mon, 12 Jun 2023 11:57:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686596241; x=1689188241; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZmIquouHkn7x7g5U3IKxu0y2ezu2hrVL9nMe9oPXqp4=; b=JzCArHR/vVvv86l8ffRKgD+LnnBpJdxVnzF/2a/TZtfWm9YNKSZvRd5JYSy1S1YbLd xDxpRpDei0bIpIm6pfSf1QJrEQNRf14tS3Y7oEP6Bjhc65tWhq16+SFgmQhBFP/AGMUA MDu4lqeZAVF4csiLn2fDRCaqcCmRJRnJhrZh3QZf1dPLCVkSUatvuvClM+8Y7ZSe0+mp gC1RCWHALEZCtUFoDCOHAXTdOF4DhxQoU4T1G3Q7kugTyuidSvbQAE2PcoR/1zIofyeU gqnR/pgQHvNIY00r3JN8elnddXPKmWTKx/OTBTs9IIAvZtRUmePQ0VJ8TULeYoUHz65R HOYg== X-Gm-Message-State: AC+VfDxiupx6aUKHNwaawFaTu7WH5qU08PuP9id1K6S94mh7qCSoUSvF CRMgJlgKgPCuf37WBEt7SliZgnh4JqpRvz13wYPCW5trIvAiGBpBpBYyHmUZDxvywCjSa2AgFmR mBWJNEAkRJX+cPhQjgOYIrtW5MQ== X-Received: by 2002:a05:6214:2b05:b0:62b:6c6f:b3e3 with SMTP id jx5-20020a0562142b0500b0062b6c6fb3e3mr12804183qvb.3.1686596241357; Mon, 12 Jun 2023 11:57:21 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6e6wlnXH8y0uBmHDsq+xF3VvQe8OmdmhPPpTZDH9TOC0T37Kc9khtjBeEOIaHB3qFNDKkviA== X-Received: by 2002:a05:6214:2b05:b0:62b:6c6f:b3e3 with SMTP id jx5-20020a0562142b0500b0062b6c6fb3e3mr12804161qvb.3.1686596241115; Mon, 12 Jun 2023 11:57:21 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id h23-20020a0cab17000000b005f227de6b1bsm3397636qvb.116.2023.06.12.11.57.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 11:57:20 -0700 (PDT) Date: Mon, 12 Jun 2023 14:57:18 -0400 From: Peter Xu To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, willy@infradead.org, hannes@cmpxchg.org, mhocko@suse.com, josef@toxicpanda.com, jack@suse.cz, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, michel@lespinasse.org, liam.howlett@oracle.com, jglisse@google.com, vbabka@suse.cz, minchan@google.com, dave@stgolabs.net, punit.agrawal@bytedance.com, lstoakes@gmail.com, hdanton@sina.com, apopple@nvidia.com, ying.huang@intel.com, david@redhat.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v2 4/6] mm: drop VMA lock before waiting for migration Message-ID: References: <20230609005158.2421285-1-surenb@google.com> <20230609005158.2421285-5-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Jun 12, 2023 at 11:44:33AM -0700, Suren Baghdasaryan wrote: > I think so. With that change getting VM_FAULT_RETRY in do_page_fault() > will guarantee that per-vma lock was dropped. Is that what you mean? Yes, with the newly added "return VM_FAULT_RETRY" in do_swap_page() for per-vma lock removed. AFAICT all the rest paths guaranteed that as long as in the fault paths. -- Peter Xu