From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67017EB64DA for ; Fri, 30 Jun 2023 23:22:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232248AbjF3XV5 (ORCPT ); Fri, 30 Jun 2023 19:21:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232242AbjF3XVi (ORCPT ); Fri, 30 Jun 2023 19:21:38 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 193E75242; Fri, 30 Jun 2023 16:20:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jvdz0LbFUd5KiEFSNFVLvK0uJCLqVYTsPuq+h53F+6E=; b=u/vsEj2FgZ9QmeEuNpjS7q+tuh hONGbehXcGJxZhd9FubfoY6WSSYbJ9UPF61udiyY3YDrjQYxphEMAEmqW13hZrjYlrxP9Aj0+80Mv lSHjcDIUUYBt37PBBzN0m+QkmonWpmQLq/GzYl2uGsUYUh8itiU4LW5ukJtsPfTYW3ijiAUHQvXGD /rpdUy97sLEY2g6GOCv+CDWGzno0N9uACVNRdj00rgV0xz+EZ4SF3kwchTHqSgRqom7nK2WZbhQIG ZmRcejFw7P/KjuG88ANRAXoXaBUnf4BHaHCr5ZC/TzjAtteUMi03cESvUlAvVzauCMdK7+4M7+MBI SpvKEtHA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qFNPi-004kne-2X; Fri, 30 Jun 2023 23:20:30 +0000 Date: Fri, 30 Jun 2023 16:20:30 -0700 From: Luis Chamberlain To: Kees Cook Cc: Tom Rix , yzaikin@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] sysctl: set variable sysctl_mount_point storage-class-specifier to static Message-ID: References: <20230611120725.183182-1-trix@redhat.com> <202306131330.AAC4C43AC@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202306131330.AAC4C43AC@keescook> Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Jun 13, 2023 at 01:30:47PM -0700, Kees Cook wrote: > On Sun, Jun 11, 2023 at 08:07:25AM -0400, Tom Rix wrote: > > smatch reports > > fs/proc/proc_sysctl.c:32:18: warning: symbol > > 'sysctl_mount_point' was not declared. Should it be static? > > > > This variable is only used in its defining file, so it should be static. > > > > Signed-off-by: Tom Rix > > Reviewed-by: Kees Cook Queued up, thanks! Luis