From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC3E3EB64DB for ; Mon, 19 Jun 2023 09:11:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230516AbjFSJLG (ORCPT ); Mon, 19 Jun 2023 05:11:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230510AbjFSJLE (ORCPT ); Mon, 19 Jun 2023 05:11:04 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7D3D1CA; Mon, 19 Jun 2023 02:11:03 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0C2DB2F4; Mon, 19 Jun 2023 02:11:47 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.28.22]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3DBA43F64C; Mon, 19 Jun 2023 02:11:02 -0700 (PDT) Date: Mon, 19 Jun 2023 10:10:56 +0100 From: Mark Rutland To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-bcachefs@vger.kernel.org, Christopher James Halse Rogers Subject: Re: [PATCH 28/32] stacktrace: Export stack_trace_save_tsk Message-ID: References: <20230509165657.1735798-1-kent.overstreet@linux.dev> <20230509165657.1735798-29-kent.overstreet@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230509165657.1735798-29-kent.overstreet@linux.dev> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, May 09, 2023 at 12:56:53PM -0400, Kent Overstreet wrote: > From: Christopher James Halse Rogers > > The bcachefs module wants it, and there doesn't seem to be any > reason it shouldn't be exported like the other functions. What is the bcachefs module using this for? Is that just for debug purposes? Assuming so, mentioning that in the commit message would be helpful. Thanks, Mark. > Signed-off-by: Christopher James Halse Rogers > Signed-off-by: Kent Overstreet > --- > kernel/stacktrace.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/kernel/stacktrace.c b/kernel/stacktrace.c > index 9ed5ce9894..4f65824879 100644 > --- a/kernel/stacktrace.c > +++ b/kernel/stacktrace.c > @@ -151,6 +151,7 @@ unsigned int stack_trace_save_tsk(struct task_struct *tsk, unsigned long *store, > put_task_stack(tsk); > return c.len; > } > +EXPORT_SYMBOL_GPL(stack_trace_save_tsk); > > /** > * stack_trace_save_regs - Save a stack trace based on pt_regs into a storage array > @@ -301,6 +302,7 @@ unsigned int stack_trace_save_tsk(struct task_struct *task, > save_stack_trace_tsk(task, &trace); > return trace.nr_entries; > } > +EXPORT_SYMBOL_GPL(stack_trace_save_tsk); > > /** > * stack_trace_save_regs - Save a stack trace based on pt_regs into a storage array > -- > 2.40.1 > >