From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AB8AC0015E for ; Tue, 27 Jun 2023 22:05:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229716AbjF0WFL (ORCPT ); Tue, 27 Jun 2023 18:05:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229488AbjF0WFK (ORCPT ); Tue, 27 Jun 2023 18:05:10 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C77D71FE5 for ; Tue, 27 Jun 2023 15:05:09 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-26307d808a4so1479010a91.1 for ; Tue, 27 Jun 2023 15:05:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20221208.gappssmtp.com; s=20221208; t=1687903509; x=1690495509; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5DYHe4bnJRWcnzs0u1zgwhRUtJrGQi+1XUL5Mm+Ohjs=; b=yMUwX+WrY5rt4zP0GksI635sC1Rp7YPOaGDvrzF3kYAXfvZhc0pBaStaiggmfgaMI2 uXHp5zmSiWZTeFXmec3EeLVLmX2Z3h7r2f8QlfT1pScDsv/oqbrB5Ld5dVQE138qdnMt D0A9DQldSDNHP/92kOy7zkW29wihZorlu7uHsSqekq+A5O8GhYnfdq9yfbggInm8HGYN pZDakz2K6IOYmmGOYjWISRAcEz6l1BI1yUXP9FcsoXj23q1vNUDkn1GouE9y3J1eJI3+ HSoen8uLEJ0DRWnfBp3+EBRV5/34Op2K5xWZu91IHqx9LUm1pVhJ3513uW+8lUg7ZTrx Pk7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687903509; x=1690495509; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5DYHe4bnJRWcnzs0u1zgwhRUtJrGQi+1XUL5Mm+Ohjs=; b=eelo+TrfHOQleiRZW9xK9Zr1bXoMkNzkGweqgT0XqkT77VZL/e7A4Jp2agW6EPxEbt hsh3I+jtZMywYIIgQYEVPPjERix5t0qYKtCZzG+SMZ/FDSh2l/OP5wLRu8XPw/cBoCoP 2P0x46F13X0fK2qFOEzGKIVuDQw9jpcWZTVO7m8EXFK027mwXnbXquLY9VRnD+TpRVjU gSXdB59kLkydSrZYcKF2KBtNh3ifLkv88GkD00lqCplrYZy6ChjOwA8XE2OFfnAIAnd6 FnQSjdekApePA3f1RwEfARPUcTmV/yrIGV8fs4iosR6BPVjRTEKIPvfsK77e8xgzP3hl Gg2w== X-Gm-Message-State: AC+VfDxTUDUx+VP61pU3weSmKXvI4rpJD0tV8ecY5Yzemm44BKZsljuI rlPGALbpCE/IkRR/mHPgQ5nSFA== X-Google-Smtp-Source: ACHHUZ51GdeT0rkklPTvRnFBvywqgG6ZZCt1e8bXjVFeoZTq0FBzGiBdbxrdCOG9WAlsKh01EySO3Q== X-Received: by 2002:a17:90a:19c9:b0:255:d86c:baec with SMTP id 9-20020a17090a19c900b00255d86cbaecmr33128882pjj.46.1687903509282; Tue, 27 Jun 2023 15:05:09 -0700 (PDT) Received: from dread.disaster.area (pa49-186-94-37.pa.vic.optusnet.com.au. [49.186.94.37]) by smtp.gmail.com with ESMTPSA id q15-20020a17090a064f00b002533ce5b261sm8935406pje.10.2023.06.27.15.05.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jun 2023 15:05:08 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1qEGo6-00GzGq-0o; Wed, 28 Jun 2023 08:05:06 +1000 Date: Wed, 28 Jun 2023 08:05:06 +1000 From: Dave Chinner To: Kent Overstreet Cc: Jens Axboe , torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-bcachefs@vger.kernel.org, Christoph Hellwig Subject: Re: [GIT PULL] bcachefs Message-ID: References: <20230626214656.hcp4puionmtoloat@moria.home.lan> <20230627000635.43azxbkd2uf3tu6b@moria.home.lan> <91e9064b-84e3-1712-0395-b017c7c4a964@kernel.dk> <20230627020525.2vqnt2pxhtgiddyv@moria.home.lan> <23922545-917a-06bd-ec92-ff6aa66118e2@kernel.dk> <20230627201524.ool73bps2lre2tsz@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230627201524.ool73bps2lre2tsz@moria.home.lan> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Jun 27, 2023 at 04:15:24PM -0400, Kent Overstreet wrote: > On Tue, Jun 27, 2023 at 11:16:01AM -0600, Jens Axboe wrote: > > On 6/26/23 8:59?PM, Jens Axboe wrote: > > > On 6/26/23 8:05?PM, Kent Overstreet wrote: > > >> On Mon, Jun 26, 2023 at 07:13:54PM -0600, Jens Axboe wrote: > > >>> Doesn't reproduce for me with XFS. The above ktest doesn't work for me > > >>> either: > > >> > > >> It just popped for me on xfs, but it took half an hour or so of looping > > >> vs. 30 seconds on bcachefs. > > > > > > OK, I'll try and leave it running overnight and see if I can get it to > > > trigger. > > > > I did manage to reproduce it, and also managed to get bcachefs to run > > the test. But I had to add: > > > > diff --git a/check b/check > > index 5f9f1a6bec88..6d74bd4933bd 100755 > > --- a/check > > +++ b/check > > @@ -283,7 +283,7 @@ while [ $# -gt 0 ]; do > > case "$1" in > > -\? | -h | --help) usage ;; > > > > - -nfs|-afs|-glusterfs|-cifs|-9p|-fuse|-virtiofs|-pvfs2|-tmpfs|-ubifs) > > + -nfs|-afs|-glusterfs|-cifs|-9p|-fuse|-virtiofs|-pvfs2|-tmpfs|-ubifs|-bcachefs) > > FSTYP="${1:1}" > > ;; > > -overlay) > > I wonder if this is due to an upstream fstests change I haven't seen > yet, I'll have a look. Run mkfs.bcachefs on the testdir first. fstests tries to probe the filesystem type to test if $FSTYP is not set. If it doesn't find a filesystem or it is unsupported, it will use the default (i.e. XFS). There should be no reason to need to specify the filesystem type for filesystems that blkid recognises. from common/config: # Autodetect fs type based on what's on $TEST_DEV unless it's been set # externally if [ -z "$FSTYP" ] && [ ! -z "$TEST_DEV" ]; then FSTYP=`blkid -c /dev/null -s TYPE -o value $TEST_DEV` fi FSTYP=${FSTYP:=xfs} export FSTYP Cheers, Dave. -- Dave Chinner david@fromorbit.com