From: Christoph Hellwig <hch@infradead.org>
To: "Ahelenia Ziemiańska" <nabijaczleweli@nabijaczleweli.xyz>
Cc: Amir Goldstein <amir73il@gmail.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Jan Kara <jack@suse.cz>,
Chung-Chiang Cheng <cccheng@synology.com>,
ltp@vger.kernel.org
Subject: Re: [PATCH v3 0/3+1] fanotify accounting for fs/splice.c
Date: Tue, 27 Jun 2023 21:51:05 -0700 [thread overview]
Message-ID: <ZJu8OUwWgz1zDVf5@infradead.org> (raw)
In-Reply-To: <cover.1687884029.git.nabijaczleweli@nabijaczleweli.xyz>
Can you please resend this outside this thread? I really cant't see
what's new or old here if you have a reply-to in the old thread.
On Tue, Jun 27, 2023 at 06:55:22PM +0200, Ahelenia Ziemiańska wrote:
> In 1/3 I've applied if/else if/else tree like you said,
> and expounded a bit in the message.
>
> This is less pretty now, however, since it turns out that
> iter_file_splice_write() already marks the out fd as written because it
> writes to it via vfs_iter_write(), and that sent a double notification.
It seems like vfs_iter_write is the wrong level to implement
->splice_write given that the the ->splice_write caller has already
checked f_mode, done the equivalent of rw_verify_area and
should do the fsnotify_modify. I'd suggest to just open code the
relevant parts of vfs_iocb_iter_write in iter_file_splice_write.
next prev parent reply other threads:[~2023-06-28 7:56 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 3:04 splice(-> FIFO) never wakes up inotify IN_MODIFY? Ahelenia Ziemiańska
2023-06-26 6:11 ` Amir Goldstein
2023-06-26 12:19 ` Ahelenia Ziemiańska
2023-06-26 12:57 ` Ahelenia Ziemiańska
2023-06-26 13:51 ` Jan Kara
2023-06-26 14:25 ` Ahelenia Ziemiańska
2023-06-26 15:00 ` Jan Kara
2023-06-26 15:15 ` Ahelenia Ziemiańska
2023-06-26 16:52 ` Jan Kara
2023-06-26 14:53 ` Amir Goldstein
2023-06-26 15:12 ` Ahelenia Ziemiańska
2023-06-26 16:21 ` Amir Goldstein
2023-06-26 17:14 ` Ahelenia Ziemiańska
2023-06-26 18:57 ` Amir Goldstein
2023-06-26 23:08 ` [PATCH v2 0/3] fanotify accounting for fs/splice.c наб
2023-06-27 6:14 ` Amir Goldstein
2023-06-27 16:55 ` [PATCH v3 0/3+1] " Ahelenia Ziemiańska
2023-06-27 16:55 ` [PATCH v3 1/3] splice: always fsnotify_access(in), fsnotify_modify(out) on success Ahelenia Ziemiańska
2023-06-27 18:10 ` Amir Goldstein
2023-06-27 20:13 ` Ahelenia Ziemiańska
2023-06-27 16:55 ` [PATCH v3 2/3] splice: fsnotify_access(fd)/fsnotify_modify(fd) in vmsplice Ahelenia Ziemiańska
2023-06-27 18:11 ` Amir Goldstein
2023-06-27 16:55 ` [PATCH v3 3/3] splice: fsnotify_access(in), fsnotify_modify(out) on success in tee Ahelenia Ziemiańska
2023-06-27 16:57 ` [LTP PATCH] inotify13: new test for fs/splice.c functions vs pipes vs inotify Ahelenia Ziemiańska
2023-06-27 18:31 ` Amir Goldstein
2023-06-27 20:59 ` [LTP RFC PATCH v2] " Ahelenia Ziemiańska
2023-06-28 0:21 ` [LTP RFC PATCH v3] " Ahelenia Ziemiańska
2023-06-28 5:30 ` Amir Goldstein
2023-06-28 16:03 ` Ahelenia Ziemiańska
2023-06-27 22:57 ` [LTP PATCH] " Petr Vorel
2023-06-27 18:03 ` [PATCH v3 0/3+1] fanotify accounting for fs/splice.c Amir Goldstein
2023-06-27 20:34 ` Ahelenia Ziemiańska
2023-06-27 20:50 ` [PATCH v4 0/3] " Ahelenia Ziemiańska
2023-06-27 20:50 ` [PATCH v4 1/3] splice: always fsnotify_access(in), fsnotify_modify(out) on success Ahelenia Ziemiańska
2023-06-28 6:33 ` Amir Goldstein
2023-06-28 10:11 ` Jan Kara
2023-06-28 17:09 ` Ahelenia Ziemiańska
2023-06-28 18:38 ` Amir Goldstein
2023-06-28 20:18 ` Ahelenia Ziemiańska
2023-06-30 11:03 ` Amir Goldstein
2023-06-27 20:50 ` [PATCH v4 2/3] splice: fsnotify_access(fd)/fsnotify_modify(fd) in vmsplice Ahelenia Ziemiańska
2023-06-27 20:51 ` [PATCH v4 3/3] splice: fsnotify_access(in), fsnotify_modify(out) on success in tee Ahelenia Ziemiańska
2023-06-28 6:02 ` [PATCH v4 0/3] fanotify accounting for fs/splice.c Amir Goldstein
2023-06-28 11:38 ` Jan Kara
2023-06-28 13:41 ` Amir Goldstein
2023-06-28 18:54 ` Ahelenia Ziemiańska
2023-06-29 8:45 ` Jan Kara
2023-06-28 4:51 ` Christoph Hellwig [this message]
2023-06-28 10:38 ` [PATCH v3 0/3+1] " Jan Kara
2023-06-26 23:09 ` [PATCH v2 1/3] splice: always fsnotify_access(in), fsnotify_modify(out) on success Ahelenia Ziemiańska
2023-06-27 6:02 ` Amir Goldstein
2023-06-26 23:09 ` [PATCH v2 2/3] splice: fsnotify_modify(fd) in vmsplice Ahelenia Ziemiańska
2023-06-27 6:27 ` Amir Goldstein
2023-06-26 23:09 ` [PATCH v2 3/3] splice: fsnotify_access(in), fsnotify_modify(out) on success in tee Ahelenia Ziemiańska
2023-06-27 6:20 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJu8OUwWgz1zDVf5@infradead.org \
--to=hch@infradead.org \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=cccheng@synology.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ltp@vger.kernel.org \
--cc=nabijaczleweli@nabijaczleweli.xyz \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).