From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00164EB64DA for ; Tue, 4 Jul 2023 18:08:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231189AbjGDSIT (ORCPT ); Tue, 4 Jul 2023 14:08:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229971AbjGDSIS (ORCPT ); Tue, 4 Jul 2023 14:08:18 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 549FD10C9; Tue, 4 Jul 2023 11:08:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/QQ+Y+14Y8wHCcIurGp5zUfHCaeH/cPOa7LyRJZnARI=; b=Uag6pglI2bOJeECLpGyALXzsbc Q0NaPAwHEDf7FUlP/Y++2CoZe9Cm2yM/WfzM38xyNpjxlNRthoaH+6Ace2usGLeqec1FC8j1iUoqi PKmLd3TiNy+i1Bvc/HhE0Dp3EKo6qISsd/heyWV/5mxMOBjFI+C9vlrpIsYCXOvVM8PNh5tNNehfn KxlKgqlat8ndp/Gw1F5SFOXdNoNt/0Izp1KAGsAAhqwjPt4Nf+0iDLq6mK0LzxfNvrCpBIABWINPV PcMg6bT9xJKvE3QNWYHvYjetkckTquJiSqb+wQH3JUVWLFSFaK0RXOeFB/rqP8IwfAygJdhyn5r0c L/MfWmQA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qGkRf-009MKK-M8; Tue, 04 Jul 2023 18:08:11 +0000 Date: Tue, 4 Jul 2023 19:08:11 +0100 From: Matthew Wilcox To: David Howells Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara Subject: Re: [PATCH 00/12] Convert write_cache_pages() to an iterator Message-ID: References: <20230626173521.459345-1-willy@infradead.org> <3130123.1687863182@warthog.procyon.org.uk> <3697885.1687982590@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3697885.1687982590@warthog.procyon.org.uk> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Jun 28, 2023 at 09:03:10PM +0100, David Howells wrote: > Matthew Wilcox wrote: > > > I'm looking at afs writeback now. > > :-) > > > fs/iomap/buffered-io.c | 14 +- > > include/linux/pagevec.h | 18 +++ > > include/linux/writeback.h | 22 ++- > > mm/page-writeback.c | 310 +++++++++++++++++++++----------------- > > 4 files changed, 216 insertions(+), 148 deletions(-) > > Documentation/mm/writeback.rst too please. $ ls Documentation/mm/w* ls: cannot access 'Documentation/mm/w*': No such file or directory $ git grep writeback Documentation/mm Documentation/mm/multigen_lru.rst:do not require TLB flushes; clean pages do not require writeback. Documentation/mm/page_migration.rst:2. Ensure that writeback is complete. Documentation/mm/page_migration.rst:15. Queued up writeback on the new page is triggered. Documentation/mm/physical_memory.rst:``nr_writeback_throttled`` Documentation/mm/physical_memory.rst: Number of pages written while reclaim is throttled waiting for writeback. Or are you suggesting I write a new piece of kernel documentation? If so, I respectfully decline. I've updated the kernel-doc included in Documentation/core-api/mm-api.rst and I think that's all I can reasonably be asked to do.