From: Christoph Hellwig <hch@infradead.org>
To: Bernd Schubert <bernd.schubert@fastmail.fm>
Cc: Hao Xu <hao.xu@linux.dev>,
fuse-devel@lists.sourceforge.net, miklos@szeredi.hu,
linux-fsdevel@vger.kernel.org, Wanpeng Li <wanpengli@tencent.com>,
cgxu519@mykernel.net, Dharmendra Singh <dsingh@ddn.com>
Subject: Re: [RFC] [PATCH] fuse: DIO writes always use the same code path
Date: Thu, 6 Jul 2023 07:43:19 -0700 [thread overview]
Message-ID: <ZKbTB+HgmtjnQqfe@infradead.org> (raw)
In-Reply-To: <a77b34fe-dbe7-388f-c559-932b1cd44583@fastmail.fm>
On Wed, Jul 05, 2023 at 12:23:40PM +0200, Bernd Schubert wrote:
> @@ -1377,37 +1375,10 @@ static ssize_t fuse_cache_write_iter(struct kiocb
> *iocb, struct iov_iter *from)
> if (err)
> goto out;
>
> - if (iocb->ki_flags & IOCB_DIRECT) {
> - loff_t pos = iocb->ki_pos;
> - written = generic_file_direct_write(iocb, from);
After this generic_file_direct_write becomes unused outside of
mm/filemap.c, please add a patch to the series to mark it static.
> + written = fuse_perform_write(iocb, mapping, from, iocb->ki_pos);
> + if (written >= 0)
> + iocb->ki_pos += written;
This needs to be updated to the new fuse_perform_write calling
conventions in Linus tree.
next prev parent reply other threads:[~2023-07-06 14:43 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 9:45 [PATCH v3 0/3] fuse: add a new fuse init flag to relax restrictions in no cache mode Hao Xu
2023-06-30 9:46 ` [PATCH 1/3] fuse: invalidate page cache pages before direct write Hao Xu
2023-06-30 10:32 ` Bernd Schubert
2023-07-21 3:34 ` [fuse-devel] " Jiachen Zhang
2023-06-30 9:46 ` [PATCH 2/3] fuse: add a new fuse init flag to relax restrictions in no cache mode Hao Xu
2023-06-30 10:35 ` Bernd Schubert
2023-06-30 9:46 ` [PATCH 3/3] fuse: write back dirty pages before direct write in direct_io_relax mode Hao Xu
2023-06-30 10:40 ` Bernd Schubert
2023-07-21 6:35 ` [External] [fuse-devel] " Jiachen Zhang
2023-07-21 11:27 ` Hao Xu
2023-07-21 11:56 ` Bernd Schubert
2023-07-25 10:11 ` Hao Xu
2023-07-25 13:00 ` Bernd Schubert
2023-07-25 16:57 ` Hao Xu
2023-07-25 17:59 ` Bernd Schubert
2023-07-27 9:42 ` Hao Xu
2023-07-26 11:07 ` Jiachen Zhang
2023-07-26 13:15 ` Bernd Schubert
2023-07-27 2:24 ` Jiachen Zhang
2023-07-27 10:31 ` Hao Xu
2023-07-28 2:57 ` Jiachen Zhang
2023-07-27 10:48 ` Hao Xu
2023-07-05 10:23 ` [RFC] [PATCH] fuse: DIO writes always use the same code path Bernd Schubert
2023-07-06 14:43 ` Christoph Hellwig [this message]
2023-07-07 13:36 ` Bernd Schubert
2023-07-17 8:03 ` Hao Xu
2023-07-17 21:17 ` Bernd Schubert
2023-07-20 7:32 ` [PATCH v3 0/3] fuse: add a new fuse init flag to relax restrictions in no cache mode Hao Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKbTB+HgmtjnQqfe@infradead.org \
--to=hch@infradead.org \
--cc=bernd.schubert@fastmail.fm \
--cc=cgxu519@mykernel.net \
--cc=dsingh@ddn.com \
--cc=fuse-devel@lists.sourceforge.net \
--cc=hao.xu@linux.dev \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).