From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78514C001B0 for ; Fri, 7 Jul 2023 13:11:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229642AbjGGNLe (ORCPT ); Fri, 7 Jul 2023 09:11:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232470AbjGGNLd (ORCPT ); Fri, 7 Jul 2023 09:11:33 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B17811FC4 for ; Fri, 7 Jul 2023 06:10:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688735445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=t1O9zb5GHKVELS5klWqCpQjcxJWJEqyoSLzfvfMUZe4=; b=jVnZiXSw6m/DEsFuKQ9K4D8xZ+zstZmIXIWLNmBH4NNrPmUc13zKsNfhdw0XZMjYGlhwn7 VGt1s4ozkDwNrKH65fmhhN1xkTGO5lLxvPl7yHxAb6bDzfWk/dCug9jRG/a7WXj/iAlZOS IEnF6NzPJcy2H0+MGrOCVI4P6kFnsFA= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-343-HkfGe1hONeiJTtp01IyYlw-1; Fri, 07 Jul 2023 09:10:44 -0400 X-MC-Unique: HkfGe1hONeiJTtp01IyYlw-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-635de6f75e0so3972296d6.1 for ; Fri, 07 Jul 2023 06:10:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688735444; x=1691327444; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=t1O9zb5GHKVELS5klWqCpQjcxJWJEqyoSLzfvfMUZe4=; b=NUmZDXaEDhJgfUMyLepw7mNVH66S+hepUHC/V31VOQkcS0SDHh8EKmO4GDbs0aSZYo tNohQmHCfOoBXizsHOMQ5qUvIcTC3slG/JIpMaAhp1zXc40TZt3UKotTqpGB3NaE/Ep8 31jWWK4B1OUcgoLLTtffNX9iwgLAFX6gy6y46X53DXAW++y13Z1+vh2dzJ3VwxQAf/zj bPPbWSyjA/48aWoXTYSJ9ByK7h9cA4SFr6ti6N/Axn/vRjAW4HVkB3TkVgoG+2kYiBlU yad5FgkE7WjUVOQiKUnV7WcdIsM8gEmzbBt4r3cVyv5Al30xhsmBK3xX77ftt41up8vR hWgg== X-Gm-Message-State: ABy/qLbdCjD6JrvlwHyoSREHOCKsw9JD6U8rdma+XrhPP63As9tKBaqm 6v9A/XOwzbM4Ylf/mFv+twKBYC7FIYB17Wcz8NKloShlTYm6LZ9d0mz1GkK0Hdqqom1bZN5A8eN 7lOqdPUc6SoFYAgptjQM3lArkRQ== X-Received: by 2002:a05:6214:b65:b0:634:cdae:9941 with SMTP id ey5-20020a0562140b6500b00634cdae9941mr5244157qvb.0.1688735444325; Fri, 07 Jul 2023 06:10:44 -0700 (PDT) X-Google-Smtp-Source: APBJJlFcMXIEnO4pEK4x9rJYrWIuHjnwN+qpj3mBxRaYTRfLT3AgJiKgGQJyC0v2TXCl9WOzVHERgw== X-Received: by 2002:a05:6214:b65:b0:634:cdae:9941 with SMTP id ey5-20020a0562140b6500b00634cdae9941mr5244120qvb.0.1688735443971; Fri, 07 Jul 2023 06:10:43 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id p8-20020a0ce188000000b0063757aea986sm2066436qvl.28.2023.07.07.06.10.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jul 2023 06:10:43 -0700 (PDT) Date: Fri, 7 Jul 2023 09:10:28 -0400 From: Peter Xu To: Axel Rasmussen Cc: Alexander Viro , Andrew Morton , Brian Geffon , Christian Brauner , David Hildenbrand , Gaosheng Cui , Huang Ying , Hugh Dickins , James Houghton , "Jan Alexander Steffens (heftig)" , Jiaqi Yan , Jonathan Corbet , Kefeng Wang , "Liam R. Howlett" , Miaohe Lin , Mike Kravetz , "Mike Rapoport (IBM)" , Muchun Song , Nadav Amit , Naoya Horiguchi , Ryan Roberts , Shuah Khan , Suleiman Souhlal , Suren Baghdasaryan , "T.J. Alumbaugh" , Yu Zhao , ZhangPeng , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v3 1/8] mm: make PTE_MARKER_SWAPIN_ERROR more general Message-ID: References: <20230706225037.1164380-1-axelrasmussen@google.com> <20230706225037.1164380-2-axelrasmussen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230706225037.1164380-2-axelrasmussen@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Jul 06, 2023 at 03:50:29PM -0700, Axel Rasmussen wrote: > diff --git a/mm/madvise.c b/mm/madvise.c > index 886f06066622..59e954586e2a 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -660,7 +660,7 @@ static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr, > free_swap_and_cache(entry); > pte_clear_not_present_full(mm, addr, pte, tlb->fullmm); > } else if (is_hwpoison_entry(entry) || > - is_swapin_error_entry(entry)) { > + is_error_swp_entry(entry)) { is_error_swp_entry() made me think whether we should call this marker as ERROR at all - it's too generic, is_error_swp_entry() can be easily read as "this swap entry is not legal". Can we come up with a less generic one? PTE_MARKER_PAGE_POISONED / PTE_MARKER_POISONED / PTE_MARKER_PAGE_ERR / ...? We do use poisoned only in real bad physical pages before, but I think we can still keep using it when applying it to a pte. I think it's fine to call a pte poisoned if it's not legal to access, just like a poisoned page. > pte_clear_not_present_full(mm, addr, pte, tlb->fullmm); > } > continue; The code change across the whole patch look good to me otherwise, thanks. -- Peter Xu