From: Matthew Wilcox <willy@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Ahelenia Ziemiańska" <nabijaczleweli@nabijaczleweli.xyz>,
"Christian Brauner" <brauner@kernel.org>,
"Jens Axboe" <axboe@kernel.dk>,
"David Howells" <dhowells@redhat.com>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Pending splice(file -> FIFO) excludes all other FIFO operations forever (was: ... always blocks read(FIFO), regardless of O_NONBLOCK on read side?)
Date: Sat, 8 Jul 2023 01:00:29 +0100 [thread overview]
Message-ID: <ZKinHejv+xBq+gti@casper.infradead.org> (raw)
In-Reply-To: <CAHk-=wgmLd78uSLU9A9NspXyTM9s6C23OVDiN2YjA-d8_S0zRg@mail.gmail.com>
On Thu, Jul 06, 2023 at 02:56:45PM -0700, Linus Torvalds wrote:
> +static int busy_pipe_buf_confirm(struct pipe_inode_info *pipe,
> + struct pipe_buffer *buf)
> +{
> + struct page *page = buf->page;
> +
> + if (folio_wait_bit_interruptible(page_folio(page), PG_locked))
> + return -EINTR;
Do we really want interruptible here rather than killable? That is,
do we want SIGWINCH or SIGALRM to result in a short read? I assume
it's OK to return a short read because userspace has explicitly asked
for O_NONBLOCK and can therefore be expected to actually check the
return value from read().
next prev parent reply other threads:[~2023-07-08 0:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 1:12 Pending splice(file -> FIFO) always blocks read(FIFO), regardless of O_NONBLOCK on read side? Ahelenia Ziemiańska
2023-06-26 9:32 ` Christian Brauner
2023-06-26 11:59 ` Pending splice(file -> FIFO) excludes all other FIFO operations forever (was: ... always blocks read(FIFO), regardless of O_NONBLOCK on read side?) Ahelenia Ziemiańska
2023-06-26 15:56 ` Christian Brauner
2023-06-26 16:14 ` Ahelenia Ziemiańska
2023-07-06 21:56 ` Linus Torvalds
2023-07-07 17:21 ` Christian Brauner
2023-07-07 19:10 ` Linus Torvalds
2023-07-07 19:57 ` Jens Axboe
2023-07-07 22:41 ` Ahelenia Ziemiańska
2023-07-07 22:57 ` Linus Torvalds
2023-07-08 0:30 ` Ahelenia Ziemiańska
2023-07-08 20:06 ` Linus Torvalds
2023-07-09 1:03 ` Ahelenia Ziemiańska
2023-07-09 22:33 ` Ahelenia Ziemiańska
2023-07-10 13:22 ` Ahelenia Ziemiańska
2023-07-08 0:00 ` Matthew Wilcox [this message]
2023-07-08 0:07 ` Linus Torvalds
2023-07-08 0:21 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKinHejv+xBq+gti@casper.infradead.org \
--to=willy@infradead.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nabijaczleweli@nabijaczleweli.xyz \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).