From: Matthew Wilcox <willy@infradead.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Wen Yang <wenyang.linux@foxmail.com>,
linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
Jens Axboe <axboe@kernel.dk>, LKML <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>,
David Woodhouse <dwmw@amazon.co.uk>,
Dylan Yudaken <dylany@fb.com>
Subject: Re: [PATCH] eventfd: avoid overflow to ULLONG_MAX when ctx->count is 0
Date: Sun, 9 Jul 2023 21:05:49 +0100 [thread overview]
Message-ID: <ZKsTHWjJsvLw6kJo@casper.infradead.org> (raw)
In-Reply-To: <add93bba-5c63-7d7f-2034-2d25b7b44ada@web.de>
On Sun, Jul 09, 2023 at 09:13:28PM +0200, Markus Elfring wrote:
> > For eventfd with flag EFD_SEMAPHORE, when its ctx->count is 0, calling
> > eventfd_ctx_do_read will cause ctx->count to overflow to ULLONG_MAX.
>
> Please choose an imperative change suggestion.
Markus, stop this nitpicking. It puts off contributors. The changelog
is perfectly clear.
next prev parent reply other threads:[~2023-07-09 20:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-09 6:54 [PATCH] eventfd: avoid overflow to ULLONG_MAX when ctx->count is 0 wenyang.linux
[not found] ` <add93bba-5c63-7d7f-2034-2d25b7b44ada@web.de>
2023-07-09 20:05 ` Matthew Wilcox [this message]
2023-07-10 14:12 ` Christian Brauner
2023-07-10 15:02 ` Wen Yang
2023-07-11 9:07 ` Christian Brauner
2023-07-11 9:39 ` Christian Brauner
2023-07-11 18:14 ` Wen Yang
2023-07-11 9:46 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKsTHWjJsvLw6kJo@casper.infradead.org \
--to=willy@infradead.org \
--cc=Markus.Elfring@web.de \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=dylany@fb.com \
--cc=hch@lst.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=wenyang.linux@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).