From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0384BEB64DD for ; Sun, 9 Jul 2023 20:06:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229921AbjGIUGD (ORCPT ); Sun, 9 Jul 2023 16:06:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbjGIUGC (ORCPT ); Sun, 9 Jul 2023 16:06:02 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56241FE; Sun, 9 Jul 2023 13:06:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0pveTWgFRr5mN5v32TgV3qLTNvcCzrdqvG9KBp/LfDM=; b=CKvxMWf1oJIhSQLDpLkOVg107b 8gXWkpndkDR6J484pKeK9yBY6PVCcnX9DT31gBUbv/3Oj1JzGoqZRA+Gm9qYPzoaJ0XQIO5LzyqPK thfGelT9Kdj9Tmn89+S+D2xa84QpAqrQSuSDPciNnd+2cbBKATfQzYVmPLHZ9uFPsZpqlO/H/bnN6 hKgcpXdx27TTyUJiTUEiDGidQN4dCRhDWbTdX/VY9IbFZxnuiSV5yM0Y8o4Zd9bJrZXydF/LHwa3P ELmkUJocCfn9vqzgWpC+MooCN1wWFdQT54RS9YMVvkHOnXBNGYW3DPZ5G3UX/KPkFCQcFGgCFfAXq s1LVW+jw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qIafF-00DyMr-3X; Sun, 09 Jul 2023 20:05:49 +0000 Date: Sun, 9 Jul 2023 21:05:49 +0100 From: Matthew Wilcox To: Markus Elfring Cc: Wen Yang , linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org, Alexander Viro , Christian Brauner , Jens Axboe , LKML , Christoph Hellwig , David Woodhouse , Dylan Yudaken Subject: Re: [PATCH] eventfd: avoid overflow to ULLONG_MAX when ctx->count is 0 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sun, Jul 09, 2023 at 09:13:28PM +0200, Markus Elfring wrote: > > For eventfd with flag EFD_SEMAPHORE, when its ctx->count is 0, calling > > eventfd_ctx_do_read will cause ctx->count to overflow to ULLONG_MAX. > > Please choose an imperative change suggestion. Markus, stop this nitpicking. It puts off contributors. The changelog is perfectly clear.