From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20EB6EB64DC for ; Mon, 10 Jul 2023 03:45:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230128AbjGJDpR (ORCPT ); Sun, 9 Jul 2023 23:45:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230080AbjGJDpQ (ORCPT ); Sun, 9 Jul 2023 23:45:16 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 078ECC3; Sun, 9 Jul 2023 20:45:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MyBw3qPFBVUJngMbpYtaVZ58lnbEWQd/Zkvilzd8c80=; b=dD9s2dB6bRn+rI0PuvHq8LurHY ZGjyHrRC3iRlNS8qTXeViIwK50G08EG2HusZcOoqWtnpFJpZQ0ET64KRSSTFAyXAs5AlzhASbxUIg 3OkP52kyxl+nqxDXprrMczjB9O7jty0Usdf78QsXcG564wqz3WRc1D88uUVRKC6pDLHsv+oU5eWYd yvv+bddQwzKtBuUbTeeweHu0ei85tZiRXisOLRRQ4kFecovQVuW645ZpAwgFpUpONqt74EBNEFPmw 2NTaRiktViktBwIlfMpX0/jTBqsnh3PAh/s5Q8BtoO8jSVhm4wJAi0J/P24I1AU4zQSGAv2ulLQw2 fA6/roqQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qIhpf-00EFMv-Ul; Mon, 10 Jul 2023 03:45:03 +0000 Date: Mon, 10 Jul 2023 04:45:03 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, Wang Yugui , Dave Chinner , "Darrick J . Wong" Subject: Re: [PATCH v3 8/8] iomap: Copy larger chunks from userspace Message-ID: References: <20230612203910.724378-1-willy@infradead.org> <20230612203910.724378-9-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Jun 13, 2023 at 08:43:49PM +0100, Matthew Wilcox wrote: > > > - copied = copy_page_from_iter_atomic(page, offset, bytes, i); > > > + copied = copy_page_from_iter_atomic(&folio->page, offset, bytes, i); > > > > Would be nice t avoid the overly long line here > > The plan is to turn that into: > > copied = copy_folio_from_iter_atomic(folio, offset, bytes, i); > > in the fairly near future. Kent bugged me to add copy_folio_from_iter_atomic() now, and he's right, so "the near future" is v4.