From: Luis Chamberlain <mcgrof@kernel.org>
To: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH mm-hotfixes] tmpfs: fix Documentation of noswap and huge mount options
Date: Mon, 24 Jul 2023 11:41:01 -0700 [thread overview]
Message-ID: <ZL7FvSghPza2vPrg@bombadil.infradead.org> (raw)
In-Reply-To: <986cb0bf-9780-354-9bb-4bf57aadbab@google.com>
On Sun, Jul 23, 2023 at 01:55:00PM -0700, Hugh Dickins wrote:
> The noswap mount option is surely not one of the three options for sizing:
> move its description down.
>
> The huge= mount option does not accept numeric values: those are just in
> an internal enum. Delete those numbers, and follow the manpage text more
> closely (but there's not yet any fadvise() or fcntl() which applies here).
>
> /sys/kernel/mm/transparent_hugepage/shmem_enabled is hard to describe, and
> barely relevant to mounting a tmpfs: just refer to transhuge.rst (while
> still using the words deny and force, to help as informal reminders).
>
> Fixes: d0f5a85442d1 ("shmem: update documentation")
> Fixes: 2c6efe9cf2d7 ("shmem: add support to ignore swap")
> Signed-off-by: Hugh Dickins <hughd@google.com>
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Thanks for fixing this and addressing the preference you wanted for
master documentation, I'll follow up again with the style fixes for the
man pages.
Luis
prev parent reply other threads:[~2023-07-24 18:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-23 20:55 [PATCH mm-hotfixes] tmpfs: fix Documentation of noswap and huge mount options Hugh Dickins
2023-07-24 18:41 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZL7FvSghPza2vPrg@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=hughd@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).