linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: huzhi001@208suo.com
Cc: tglx@linutronix.de, senozhatsky@chromium.org,
	adobriyan@gmail.com, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] proc: Fix four errors in kmsg.c
Date: Fri, 14 Jul 2023 10:22:47 +0200	[thread overview]
Message-ID: <ZLEF16qgcTOaLMIk@alley> (raw)
In-Reply-To: <2f88487fa9f29eeb5a5bd4b6946a7e4c@208suo.com>

On Fri 2023-07-14 14:57:59, huzhi001@208suo.com wrote:
> The following checkpatch errors are removed:
> ERROR: "foo * bar" should be "foo *bar"
> ERROR: "foo * bar" should be "foo *bar"
> ERROR: "foo * bar" should be "foo *bar"
> ERROR: "foo * bar" should be "foo *bar"

Please, do not do fix these cosmetic issues reported by checkpatch.pl.
It is not worth the effort. In fact, it is contra productive.
It complicates the git history, backports.

I suggest to find an area in the kernel which might be interesting
for you (any driver or subsystem, ...) and try to fix a real bug
there or implement a real feature.

You might start with reading the related discussions on lkml or
related mailing list, reviewing or testing patches, ...

Best Regards,
Petr

  reply	other threads:[~2023-07-14  8:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tencent_053A1A860EFB7AAD92B2409B9D5AE06AB507@qq.com>
2023-07-14  6:57 ` [PATCH] proc: Fix four errors in kmsg.c huzhi001
2023-07-14  8:22   ` Petr Mladek [this message]
2023-07-14  8:31     ` Petr Mladek
2023-07-17  6:05     ` Sergey Senozhatsky
2023-07-17  6:08       ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZLEF16qgcTOaLMIk@alley \
    --to=pmladek@suse.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=huzhi001@208suo.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=senozhatsky@chromium.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).