From: Luis Chamberlain <mcgrof@kernel.org>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Ignat Korchagin <ignat@cloudflare.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Daniel Dao <dqminh@cloudflare.com>,
Dave Chinner <david@fromorbit.com>,
kernel-team <kernel-team@cloudflare.com>,
linux-fsdevel@vger.kernel.org,
Chandan Babu R <chandanrlinux@gmail.com>,
Leah Rumancik <lrumancik@google.com>,
linux-xfs <linux-xfs@vger.kernel.org>,
Fred Lawler <fred@cloudflare.com>
Subject: Re: Backporting of series xfs/iomap: fix data corruption due to stale cached iomap
Date: Thu, 20 Jul 2023 11:30:03 -0700 [thread overview]
Message-ID: <ZLl9K7jODHNYybTY@bombadil.infradead.org> (raw)
In-Reply-To: <CAOQ4uxgvawD4=4g8BaRiNvyvKN1oreuov_ie6sK6arq3bf8fxw@mail.gmail.com>
On Thu, Jul 20, 2023 at 09:45:14AM +0300, Amir Goldstein wrote:
> On Wed, Jul 19, 2023 at 11:37 PM Ignat Korchagin <ignat@cloudflare.com> wrote:
> >
> > Circling back on this. So far it seems that the patchset in question
> > does fix the issues of rocksdb corruption as we haven't seen them for
> > some time on our test group. We're happy to dedicate some efforts now
> > to get them officially backported to 6.1 according to the process. We
> > did try basic things with kdevops and would like to learn more. Fred
> > (cc-ed here) is happy to drive the effort and be the primary contact
> > on this. Could you, please, guide us/him on the process?
> >
>
> Hi Fred,
>
> I'd love to help you get started with kdevops and xfs testing.
> However, I am going on vacation tomorrow for three weeks,
> so I'll just drop a few pointers and let the others help you out.
>
> Luis (@mcgrof) is your best point of contact for kdevops.
I'm happy to help.
> Chandan should be able to help you with xfs backporting questions.
>
> Better yet, use the discord channel:
> https://bit.ly/linux-kdevops-chat
>
> Someone is almost always available to answer questions there.
Indeed and also on irc.oftc.net on #kdevops too if you prefer IRC.
But discord seems to be more happening for kdevops these days.
> TESTING:
> --------------
> The most challenging part of running fstests with kdevops is
> establishing the baseline (which tests pass in current 6.1.y per xfs config),
> but the baseline for that has already been established and committed
> in kdevops repo.
>
> There is a little quirk, that the baseline is associated only with exact
> kernel version, hence commits like:
> * c4e3de1 bootlinux: add expunge link for v6.1.39
Indeed so our latest baseline is in
workflows/fstests/expunges/6.1.39/xfs/unassigned/
> Make sure that you test your patches against one of those tags
> or add new symlinks to other tags.
> Start by running a sanity test without your patches, because different
> running environments and kdevops configs may disagree on the baseline.
You want to first run at least one loop to confirm your setup is fine
and that you don't find any other failures other than the ones above.
> You can use kdevops to either run local VMs with libvirt or launch
> cloud VMs with terraform - you need to configure this and more
> during the 'make menuconfig' step.
> Attaching my kdevops config (for libvirt guests) as a reference.
Please read:
https://github.com/linux-kdevops/kdevops
https://github.com/linux-kdevops/kdevops/blob/master/docs/requirements.md
https://github.com/linux-kdevops/kdevops/blob/master/docs/kdevops-first-run.md
https://github.com/linux-kdevops/kdevops/blob/master/docs/kdevops-mirror.md
And the video demonstrations. Then I'm happy to schedule some time to
cover anything the docs didn't cover, in particular to help you test new
patches you wish to backport for a stable kernel and the testing
criteria for that.
Luis
next prev parent reply other threads:[~2023-07-20 18:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 16:09 Backporting of series xfs/iomap: fix data corruption due to stale cached iomap Daniel Dao
2023-06-29 16:34 ` Matthew Wilcox
2023-06-29 18:14 ` Darrick J. Wong
2023-06-29 19:30 ` Ignat Korchagin
2023-06-30 10:39 ` Amir Goldstein
2023-06-30 12:30 ` Ignat Korchagin
2023-06-30 13:05 ` Amir Goldstein
2023-06-30 15:16 ` Darrick J. Wong
2023-07-19 20:37 ` Ignat Korchagin
2023-07-20 6:45 ` Amir Goldstein
2023-07-20 18:30 ` Luis Chamberlain [this message]
2023-07-20 18:38 ` Frederick Lawler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLl9K7jODHNYybTY@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=amir73il@gmail.com \
--cc=chandanrlinux@gmail.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=dqminh@cloudflare.com \
--cc=fred@cloudflare.com \
--cc=ignat@cloudflare.com \
--cc=kernel-team@cloudflare.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=lrumancik@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).