From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EF29C0015E for ; Thu, 20 Jul 2023 18:30:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232036AbjGTSaL (ORCPT ); Thu, 20 Jul 2023 14:30:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232048AbjGTSaH (ORCPT ); Thu, 20 Jul 2023 14:30:07 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABFFDE44; Thu, 20 Jul 2023 11:30:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description; bh=yi1OQndfSAKROqv7J0RkOh857pRhe/ujJHjrZQ98YWs=; b=u1872vr6m+1g/EyQr5YbAPgIXi 8iuoeRHRChMThcfhq3UY4wdI2nXNzWYwgSIa+3FDugCI22X9Bm1XyJGiHJIu6D5kJQ9V0G5MO4iSE OCY/rnMGrX1oQMmEiQ6EuF5nDQiX+ItXKTRxJ9DE/fIzrL9ODNmxrh9E1IxReSdEhLdvD66Ms/603 blSaDFm4qvspOBzeZCxfkeVeDnuHwotDQpz6ndikocgFBQUi1Ogq9+0S6tu/LSy8MI/j+CE58dhM4 SRty9xES0AVwyKdaUEC6HK5PTRUFutpUlznQI77UF5EffHqLSujOGKQT1cY/f22YqEvy8xv5GJ1j3 qxNb+hRw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qMYPb-00Bu2n-0Y; Thu, 20 Jul 2023 18:30:03 +0000 Date: Thu, 20 Jul 2023 11:30:03 -0700 From: Luis Chamberlain To: Amir Goldstein Cc: Ignat Korchagin , "Darrick J. Wong" , Matthew Wilcox , Daniel Dao , Dave Chinner , kernel-team , linux-fsdevel@vger.kernel.org, Chandan Babu R , Leah Rumancik , linux-xfs , Fred Lawler Subject: Re: Backporting of series xfs/iomap: fix data corruption due to stale cached iomap Message-ID: References: <20230629181408.GM11467@frogsfrogsfrogs> <20230630151657.GJ11441@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Jul 20, 2023 at 09:45:14AM +0300, Amir Goldstein wrote: > On Wed, Jul 19, 2023 at 11:37 PM Ignat Korchagin wrote: > > > > Circling back on this. So far it seems that the patchset in question > > does fix the issues of rocksdb corruption as we haven't seen them for > > some time on our test group. We're happy to dedicate some efforts now > > to get them officially backported to 6.1 according to the process. We > > did try basic things with kdevops and would like to learn more. Fred > > (cc-ed here) is happy to drive the effort and be the primary contact > > on this. Could you, please, guide us/him on the process? > > > > Hi Fred, > > I'd love to help you get started with kdevops and xfs testing. > However, I am going on vacation tomorrow for three weeks, > so I'll just drop a few pointers and let the others help you out. > > Luis (@mcgrof) is your best point of contact for kdevops. I'm happy to help. > Chandan should be able to help you with xfs backporting questions. > > Better yet, use the discord channel: > https://bit.ly/linux-kdevops-chat > > Someone is almost always available to answer questions there. Indeed and also on irc.oftc.net on #kdevops too if you prefer IRC. But discord seems to be more happening for kdevops these days. > TESTING: > -------------- > The most challenging part of running fstests with kdevops is > establishing the baseline (which tests pass in current 6.1.y per xfs config), > but the baseline for that has already been established and committed > in kdevops repo. > > There is a little quirk, that the baseline is associated only with exact > kernel version, hence commits like: > * c4e3de1 bootlinux: add expunge link for v6.1.39 Indeed so our latest baseline is in workflows/fstests/expunges/6.1.39/xfs/unassigned/ > Make sure that you test your patches against one of those tags > or add new symlinks to other tags. > Start by running a sanity test without your patches, because different > running environments and kdevops configs may disagree on the baseline. You want to first run at least one loop to confirm your setup is fine and that you don't find any other failures other than the ones above. > You can use kdevops to either run local VMs with libvirt or launch > cloud VMs with terraform - you need to configure this and more > during the 'make menuconfig' step. > Attaching my kdevops config (for libvirt guests) as a reference. Please read: https://github.com/linux-kdevops/kdevops https://github.com/linux-kdevops/kdevops/blob/master/docs/requirements.md https://github.com/linux-kdevops/kdevops/blob/master/docs/kdevops-first-run.md https://github.com/linux-kdevops/kdevops/blob/master/docs/kdevops-mirror.md And the video demonstrations. Then I'm happy to schedule some time to cover anything the docs didn't cover, in particular to help you test new patches you wish to backport for a stable kernel and the testing criteria for that. Luis