From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F0F2C001DE for ; Sun, 30 Jul 2023 11:19:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229742AbjG3LTH (ORCPT ); Sun, 30 Jul 2023 07:19:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjG3LTG (ORCPT ); Sun, 30 Jul 2023 07:19:06 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FAEC1993; Sun, 30 Jul 2023 04:19:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kbiG19oZd/dSLtXDQyp/3XUeAYx519PsJLOOLc1diN8=; b=FcIwHFr1i0uI+4Q3Gz2kHXpaz/ 8PgE6DxOAjio4iAk93OSpSPJDPmQ0IkXSn8fqF1f5WbwAVPa9LDEJFVuyz93BBNbNJ65bRGqFglAI 5/B/BCsWZy4FfbSdVZoezNwjJ9QqWhFJNLHEU522nAQacE/f2K85CYniJur3g2JizBbWG86YFHSME O8t04Ax7RTohEVH8BqB8FGr5t9+EY4S86SrbDJvhwFROsNr711hyHv/pV++/gPU4N5jDOV/t71d7z CnHWLlTKUH7FpOjPlBM3Q2oni+ETqrKBSDEwRzwqLE6FJSJtKhN3sHPpstpV/klY75i+msbXMkz3f 3QZ2fzAg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qQ4Rr-00Dsdl-5I; Sun, 30 Jul 2023 11:18:55 +0000 Date: Sun, 30 Jul 2023 12:18:55 +0100 From: Matthew Wilcox To: Zhu Yanjun Cc: linux-mm@kvack.org, Andrew Morton , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 03/13] scatterlist: Add sg_set_folio() Message-ID: References: <20230621164557.3510324-1-willy@infradead.org> <20230621164557.3510324-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sun, Jul 30, 2023 at 07:01:26PM +0800, Zhu Yanjun wrote: > Does the following function have folio version? > > " > int sg_alloc_append_table_from_pages(struct sg_append_table *sgt_append, > struct page **pages, unsigned int n_pages, unsigned int offset, > unsigned long size, unsigned int max_segment, > unsigned int left_pages, gfp_t gfp_mask) > " No -- I haven't needed to convert anything that uses sg_alloc_append_table_from_pages() yet. It doesn't look like it should be _too_ hard to add a folio version.