From: Matthew Wilcox <willy@infradead.org>
To: Christian Brauner <brauner@kernel.org>
Cc: Jeff Layton <jlayton@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] fs: fix request_mask variable in generic_fillattr kerneldoc comment
Date: Mon, 31 Jul 2023 13:32:04 +0100 [thread overview]
Message-ID: <ZMepxLLgo/Iqtj0N@casper.infradead.org> (raw)
In-Reply-To: <20230731-gefeiert-ermangelung-077409c95c9d@brauner>
On Mon, Jul 31, 2023 at 02:28:49PM +0200, Christian Brauner wrote:
> On Mon, Jul 31, 2023 at 01:18:55PM +0100, Matthew Wilcox wrote:
> > On Mon, Jul 31, 2023 at 06:37:10AM -0400, Jeff Layton wrote:
> > > /**
> > > * generic_fillattr - Fill in the basic attributes from the inode struct
> > > - * @idmap: idmap of the mount the inode was found from
> > > - * @req_mask statx request_mask
> > > - * @inode: Inode to use as the source
> > > - * @stat: Where to fill in the attributes
> > > + * @idmap: idmap of the mount the inode was found from
> > > + * @request_mask statx request_mask
> >
> > Missing the colon after request_mask.
>
> Fixed in-tree, thanks!
FWIW, a W=1 build will catch this:
../mm/filemap.c:254: warning: Function parameter or member 'folio' not described in 'filemap_remove_folio'
(after having deliberately removed the colon on that line)
next prev parent reply other threads:[~2023-07-31 12:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 10:37 [PATCH] fs: fix request_mask variable in generic_fillattr kerneldoc comment Jeff Layton
2023-07-31 12:18 ` Matthew Wilcox
2023-07-31 12:28 ` Christian Brauner
2023-07-31 12:32 ` Matthew Wilcox [this message]
2023-07-31 12:44 ` Christian Brauner
2023-07-31 12:22 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMepxLLgo/Iqtj0N@casper.infradead.org \
--to=willy@infradead.org \
--cc=brauner@kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).