From: Matthew Wilcox <willy@infradead.org>
To: David Hildenbrand <david@redhat.com>
Cc: Suren Baghdasaryan <surenb@google.com>,
akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@suse.com,
josef@toxicpanda.com, jack@suse.cz, ldufour@linux.ibm.com,
laurent.dufour@fr.ibm.com, michel@lespinasse.org,
liam.howlett@oracle.com, jglisse@google.com, vbabka@suse.cz,
minchan@google.com, dave@stgolabs.net,
punit.agrawal@bytedance.com, lstoakes@gmail.com,
hdanton@sina.com, apopple@nvidia.com, peterx@redhat.com,
ying.huang@intel.com, yuzhao@google.com, dhowells@redhat.com,
hughd@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org,
pasha.tatashin@soleen.com, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@android.com
Subject: Re: [PATCH v7 0/6] Per-VMA lock support for swap and userfaults
Date: Thu, 10 Aug 2023 23:00:55 +0100 [thread overview]
Message-ID: <ZNVeF29xUXhDwB3U@casper.infradead.org> (raw)
In-Reply-To: <01e20a4a-35dc-b342-081f-0edaf8780f51@redhat.com>
On Thu, Aug 10, 2023 at 09:40:57AM +0200, David Hildenbrand wrote:
> I won't lie: all of these locking checks are a bit hard to get and possibly
> even harder to maintain.
>
> Maybe better mmap unlock sanity checks as spelled out above might help
> improve part of the situation.
>
>
> And maybe some comments regarding the placement might help as well ;)
The placement was obvious; we can't call into drivers under the vma
lock. Not until we've audited all of them. I haven't yet had the
chance to figure out exactly what is being fixed with this patch ...
give me a few minutes.
next prev parent reply other threads:[~2023-08-10 22:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 21:19 [PATCH v7 0/6] Per-VMA lock support for swap and userfaults Suren Baghdasaryan
2023-06-30 21:19 ` [PATCH v7 1/6] swap: remove remnants of polling from read_swap_cache_async Suren Baghdasaryan
2023-06-30 21:19 ` [PATCH v7 2/6] mm: add missing VM_FAULT_RESULT_TRACE name for VM_FAULT_COMPLETED Suren Baghdasaryan
2023-06-30 21:19 ` [PATCH v7 3/6] mm: drop per-VMA lock when returning VM_FAULT_RETRY or VM_FAULT_COMPLETED Suren Baghdasaryan
2023-06-30 21:19 ` [PATCH v7 4/6] mm: change folio_lock_or_retry to use vm_fault directly Suren Baghdasaryan
2023-06-30 21:19 ` [PATCH v7 5/6] mm: handle swap page faults under per-VMA lock Suren Baghdasaryan
2023-06-30 21:19 ` [PATCH v7 6/6] mm: handle userfaults under VMA lock Suren Baghdasaryan
2023-07-02 17:50 ` [PATCH v7 0/6] Per-VMA lock support for swap and userfaults Andrew Morton
2023-07-03 15:27 ` Suren Baghdasaryan
2023-08-09 7:48 ` David Hildenbrand
2023-08-09 14:28 ` Suren Baghdasaryan
2023-08-09 15:22 ` Suren Baghdasaryan
2023-08-09 17:17 ` Suren Baghdasaryan
2023-08-09 18:04 ` David Hildenbrand
2023-08-09 18:08 ` Suren Baghdasaryan
2023-08-09 18:31 ` Suren Baghdasaryan
2023-08-10 5:29 ` Suren Baghdasaryan
2023-08-10 6:24 ` Suren Baghdasaryan
2023-08-10 7:40 ` David Hildenbrand
2023-08-10 20:20 ` Suren Baghdasaryan
2023-08-10 22:00 ` Matthew Wilcox [this message]
2023-08-10 22:16 ` Matthew Wilcox
2023-08-10 23:29 ` Suren Baghdasaryan
2023-08-10 23:43 ` Suren Baghdasaryan
2023-08-11 6:13 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNVeF29xUXhDwB3U@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=brauner@kernel.org \
--cc=dave@stgolabs.net \
--cc=david@redhat.com \
--cc=dhowells@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=hdanton@sina.com \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=jglisse@google.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@android.com \
--cc=laurent.dufour@fr.ibm.com \
--cc=ldufour@linux.ibm.com \
--cc=liam.howlett@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=mhocko@suse.com \
--cc=michel@lespinasse.org \
--cc=minchan@google.com \
--cc=pasha.tatashin@soleen.com \
--cc=peterx@redhat.com \
--cc=punit.agrawal@bytedance.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=ying.huang@intel.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).