From: Matthew Wilcox <willy@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Christian Brauner <christian@brauner.io>,
Linus Torvalds <torvalds@linux-foundation.org>,
jlayton@kernel.org, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] iov_iter: Convert iterate*() to inline funcs
Date: Mon, 14 Aug 2023 14:23:28 +0100 [thread overview]
Message-ID: <ZNoq0PNpFM8l8vAe@casper.infradead.org> (raw)
In-Reply-To: <3710261.1691764329@warthog.procyon.org.uk>
On Fri, Aug 11, 2023 at 03:32:09PM +0100, David Howells wrote:
> @@ -578,10 +683,11 @@ size_t copy_page_from_iter_atomic(struct page *page, unsigned offset, size_t byt
> kunmap_atomic(kaddr);
> return 0;
> }
> - iterate_and_advance(i, bytes, base, len, off,
> - copyin(p + off, base, len),
> - memcpy_from_iter(i, p + off, base, len)
> - )
> +
> + bytes = iterate_and_advance(i, bytes, p,
> + copy_from_user_iter,
> + iov_iter_is_copy_mc(i) ?
> + memcpy_from_iter_mc : memcpy_from_iter);
> kunmap_atomic(kaddr);
> return bytes;
> }
Please work against linux-next; this function is completely rewritten
there.
next prev parent reply other threads:[~2023-08-14 13:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 14:32 [RFC PATCH] iov_iter: Convert iterate*() to inline funcs David Howells
2023-08-11 16:38 ` Linus Torvalds
2023-08-11 17:07 ` David Howells
2023-08-11 18:08 ` Linus Torvalds
2023-08-14 13:13 ` David Howells
2023-08-14 13:23 ` Matthew Wilcox [this message]
2023-08-15 11:12 ` David Laight
2023-08-15 12:51 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNoq0PNpFM8l8vAe@casper.infradead.org \
--to=willy@infradead.org \
--cc=axboe@kernel.dk \
--cc=christian@brauner.io \
--cc=dhowells@redhat.com \
--cc=hch@lst.de \
--cc=jlayton@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).