From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 879F7EE49AA for ; Tue, 22 Aug 2023 16:40:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237390AbjHVQk6 (ORCPT ); Tue, 22 Aug 2023 12:40:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229625AbjHVQk5 (ORCPT ); Tue, 22 Aug 2023 12:40:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AB001B0; Tue, 22 Aug 2023 09:40:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DE063629E0; Tue, 22 Aug 2023 16:40:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B0B8C433C7; Tue, 22 Aug 2023 16:40:42 +0000 (UTC) Date: Tue, 22 Aug 2023 17:40:38 +0100 From: Catalin Marinas To: Mark Brown Cc: Will Deacon , Jonathan Corbet , Andrew Morton , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Arnd Bergmann , Oleg Nesterov , Eric Biederman , Kees Cook , Shuah Khan , "Rick P. Edgecombe" , Deepak Gupta , Ard Biesheuvel , Szabolcs Nagy , "H.J. Lu" , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v4 21/36] arm64/mm: Implement map_shadow_stack() Message-ID: References: <20230807-arm64-gcs-v4-0-68cfa37f9069@kernel.org> <20230807-arm64-gcs-v4-21-68cfa37f9069@kernel.org> <9c722954-8f30-425e-a0a4-6edad463620f@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9c722954-8f30-425e-a0a4-6edad463620f@sirena.org.uk> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Aug 18, 2023 at 06:08:52PM +0100, Mark Brown wrote: > On Fri, Aug 11, 2023 at 05:38:24PM +0100, Catalin Marinas wrote: > > > Given that we won't have an mmap(PROT_SHADOW_STACK), are we going to > > have restrictions on mprotect()? E.g. it would be useful to reject a > > PROT_EXEC on the shadow stack. > > mprotect() uses arch_validate_flags() which we're already having cover > this so it's already covered. I searched the patches and there's no change to the arm64 arch_validate_flags(). Maybe I missed it. -- Catalin