From: Christoph Hellwig <hch@infradead.org>
To: Bernd Schubert <bschubert@ddn.com>
Cc: linux-btrfs@vger.kernel.org, bernd.schubert@fastmail.fm,
miklos@szeredi.hu, dsingh@ddn.com,
Christoph Hellwig <hch@infradead.org>,
Goldwyn Rodrigues <rgoldwyn@suse.com>,
David Sterba <dsterba@suse.com>,
linux-fsdevel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/1] btrfs: file_remove_privs needs an exclusive lock
Date: Fri, 8 Sep 2023 01:22:07 -0700 [thread overview]
Message-ID: <ZPrZr4PEwnyYCPpC@infradead.org> (raw)
In-Reply-To: <20230906155903.3287672-2-bschubert@ddn.com>
On Wed, Sep 06, 2023 at 05:59:03PM +0200, Bernd Schubert wrote:
> file_remove_privs might call into notify_change(), which
> requires to hold an exclusive lock.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
FYI, I'd be really curious about benchmarking this against you version
that checks xattrs for shared locked writes on files that have xattrs
but not security ones or setuid bits. On the one hand being able to
do the shared lock sounds nice, on the other hand even just looking up
the xattrs will probably make it slower at least for smaller I/O.
next prev parent reply other threads:[~2023-09-08 8:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 15:59 [PATCH v3 0/1] btrfs: Use exclusive lock for file_remove_privs Bernd Schubert
2023-09-06 15:59 ` [PATCH 1/1] btrfs: file_remove_privs needs an exclusive lock Bernd Schubert
2023-09-08 8:22 ` Christoph Hellwig [this message]
2023-09-08 9:16 ` Bernd Schubert
2023-09-08 21:58 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPrZr4PEwnyYCPpC@infradead.org \
--to=hch@infradead.org \
--cc=bernd.schubert@fastmail.fm \
--cc=bschubert@ddn.com \
--cc=dsingh@ddn.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=rgoldwyn@suse.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).