From: Mateusz Guzik <mjguzik@gmail.com>
To: Sven Schnelle <svens@linux.ibm.com>
Cc: Mark Brown <broonie@kernel.org>,
Christian Brauner <brauner@kernel.org>,
Jann Horn <jannh@google.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: Test failure from "file: convert to SLAB_TYPESAFE_BY_RCU"
Date: Fri, 6 Oct 2023 14:39:21 +0200 [thread overview]
Message-ID: <ZR//+QDRI3sBpqY4@f> (raw)
In-Reply-To: <yt9dil7k151d.fsf@linux.ibm.com>
On Fri, Oct 06, 2023 at 11:19:58AM +0200, Sven Schnelle wrote:
> I'm seeing the same with the strace test-suite on s390. The problem is
> that /proc/*/fd now contains the file descriptors of the calling
> process, and not the target process.
>
This is why:
+static inline struct file *files_lookup_fdget_rcu(struct files_struct *files, unsigned int fd)
+{
+ RCU_LOCKDEP_WARN(!rcu_read_lock_held(),
+ "suspicious rcu_dereference_check() usage");
+ return lookup_fdget_rcu(fd);
+}
files argument is now thrown away, instead it always uses current.
next prev parent reply other threads:[~2023-10-06 12:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 0:04 Test failure from "file: convert to SLAB_TYPESAFE_BY_RCU" Mark Brown
2023-10-06 8:38 ` Christian Brauner
2023-10-06 19:47 ` Christian Brauner
2023-10-06 9:19 ` Sven Schnelle
2023-10-06 12:39 ` Mateusz Guzik [this message]
2023-10-06 12:54 ` Sven Schnelle
2023-10-06 13:21 ` Mateusz Guzik
2023-10-06 19:49 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZR//+QDRI3sBpqY4@f \
--to=mjguzik@gmail.com \
--cc=brauner@kernel.org \
--cc=broonie@kernel.org \
--cc=jannh@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).