From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9539CCE7A8A for ; Sun, 24 Sep 2023 21:56:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229553AbjIXV4u (ORCPT ); Sun, 24 Sep 2023 17:56:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229480AbjIXV4t (ORCPT ); Sun, 24 Sep 2023 17:56:49 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68EDBFC for ; Sun, 24 Sep 2023 14:56:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=t0dWRs0AcgJslUYwJm+3ICfi/SDNmg7iKfq/0Kh1WAc=; b=hj/JQqXGV4LZ1Z56d6uW9HOEmC h2nSL/RQeHQdmbLgcsXYyTTIhfVpUfzo0RSpfO8Qy/0NaJMG5mUjzTQXFsRcpa2iHCgFB2OxKpjrf mEnjzJQUAfWuhgE/E6fYv1IYmk5xyimJpfVJnJzRrj4la+FwJFrZSJqMqV3oLI29NO6Ed42pxpVxk RGtSU8OgA6Fdn0hlSTypKCnmQBXDzEnOZAXEzOuAopSjNtIVXQ4l+zFIHGWdPTxzwXIQ7RBLEm5GE YwZl9gqhnzKo36mTX6VfjbwharVBeq53EXWAJVI5OWxPQwVTk7qIf8XPDeed+smEANcyzcxih4nzL JlLG2VSQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qkX5Y-00FGVf-Mo; Sun, 24 Sep 2023 21:56:28 +0000 Date: Sun, 24 Sep 2023 22:56:28 +0100 From: Matthew Wilcox To: Amir Goldstein Cc: kernel test robot , Reuben Hawkins , brauner@kernel.org, Cyril Hrubis , mszeredi@redhat.com, lkp@intel.com, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, oe-lkp@lists.linux.dev, ltp@lists.linux.it, Jan Kara Subject: Re: [LTP] [PATCH] vfs: fix readahead(2) on block devices Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sun, Sep 24, 2023 at 06:32:30PM +0300, Amir Goldstein wrote: > On Sun, Sep 24, 2023 at 5:27 PM Matthew Wilcox wrote: > > > > On Sun, Sep 24, 2023 at 02:47:42PM +0300, Amir Goldstein wrote: > > > Since you joined the discussion, you have the opportunity to agree or > > > disagree with our decision to change readahead() to ESPIPE. > > > Judging by your citing of lseek and posix_fadvise standard, > > > I assume that you will be on board? > > > > I'm fine with returning ESPIPE (it's like ENOTTY in a sense). but > > that's not what kbuild reported: > > kbuild report is from v1 patch that was posted to the list > this is not the patch (v2) that is applied to vfs.misc > and has been in linux-next for a few days. Ah! I was confused. > > I think that should > > also return ESPIPE. I think posix_fadvise() should return ESPIPE on a > > socket too, but reporting bugs to the Austin Group seems quite painful. > > Perhaps somebody has been through this process and can do that for us? > > This is Reuben's first kernel patch. > Let's agree that changing the standard of posix_fadvise() for socket is > beyond the scope of his contribution :) Thank you for shepherding his first contribution. Unfortunately, this is rather the way of it when you start to pick at something ... you find more things that are broken. It's rather unusual that this one turned out to be "The POSIX spec has a defect" ;-) But yes, I'm content with v2 if v2 does in fact return ESPIPE for readahead() on a socket. Let's wait to find out. We can address the POSIX defect later.