From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3267DE7735F for ; Sat, 30 Sep 2023 09:03:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232523AbjI3JD6 (ORCPT ); Sat, 30 Sep 2023 05:03:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231311AbjI3JD4 (ORCPT ); Sat, 30 Sep 2023 05:03:56 -0400 Received: from nautica.notk.org (ipv6.notk.org [IPv6:2001:41d0:1:7a93::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A98A3195; Sat, 30 Sep 2023 02:03:53 -0700 (PDT) Received: by nautica.notk.org (Postfix, from userid 108) id 9A087C01D; Sat, 30 Sep 2023 11:03:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1696064629; bh=59HjiSLDEo3+ACXnA5m66IoUgd/1egFkIi0M5pdESts=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Uh6aS3FToSiY1OuqcKcYZQBx6bn7jOph77qLpcDrgGOejGkSJlCopVeE57cMCpl8U mQkJUBPzCO7xzUeTIT3DlKQ7KeowF/NyI2a/JQygNNMSOuzUg0QIoH+ZX6os83LiVd V/stCmX3JK1bVJhmjP458/WL9RtXIF8fXzRNtO9JkeHgEtJgiUufVCF6yXENZh++Np jSB3QGJAmujXIgKKA40r8LT/9ues0cmjPzI7YIFW8Zr1ApBs3mXazL26te0efbbiDp /UdvGdBLlvGscmcpWgFtqVI1aNTt7Zmed/rNaLlzhYyhe7x2WddbnltlyUBOHcSmER Nf8JiQ8uFd75g== Received: from gaia (localhost [127.0.0.1]) by nautica.notk.org (Postfix) with ESMTPS id C7991C009; Sat, 30 Sep 2023 11:03:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1696064618; bh=59HjiSLDEo3+ACXnA5m66IoUgd/1egFkIi0M5pdESts=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iw0vHfxRkAHS1WfrcDJdZmjG5MMjaNPpGr+3uo2ujOYAGp3KLHj8VUDhrDJ8oEcAF U+os1aA5XJxPhVIujNlfifVYvjhaXAq7KmE6+k2mRxHb4ze+GDNotHcNxGYz8N8cwT pO3zg2egZxTOYHxeTGHqh7x89o2ajW6Gu/n7iOqaicYyiybcQYPlxKHauFsfzOzAmk Hw/6RjA3H6k+sDKaLW68ayZplMEcli3uBwdIvitEAEKQNDmkvwkF0sXT/5zpMu834h 1DtzBTRnq8lk8yDcEI7rTlkgIXpVl35SC1uPl61GCTfUq9W+l6bBk0h0/htYLHeyAO mkQdNslNkGyUg== Received: from localhost (gaia [local]) by gaia (OpenSMTPD) with ESMTPA id bceda604; Sat, 30 Sep 2023 09:03:32 +0000 (UTC) Date: Sat, 30 Sep 2023 18:03:17 +0900 From: Dominique Martinet To: Eric Van Hensbergen Cc: Christian Schoenebeck , Alexander Viro , Christian Brauner , linux-fsdevel@vger.kernel.org, Wedson Almeida Filho , linux-kernel@vger.kernel.org, Wedson Almeida Filho , Latchesar Ionkov , v9fs@lists.linux.dev Subject: Re: [PATCH 03/29] 9p: move xattr-related structs to .rodata Message-ID: References: <20230930050033.41174-1-wedsonaf@gmail.com> <20230930050033.41174-4-wedsonaf@gmail.com> <41368837.HejemxxR3G@silver> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <41368837.HejemxxR3G@silver> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Christian Schoenebeck wrote on Sat, Sep 30, 2023 at 10:12:25AM +0200: > On Saturday, September 30, 2023 7:00:07 AM CEST Wedson Almeida Filho wrote: > > From: Wedson Almeida Filho > > > > This makes it harder for accidental or malicious changes to > > v9fs_xattr_user_handler, v9fs_xattr_trusted_handler, > > v9fs_xattr_security_handler, or v9fs_xattr_handlers at runtime. > > > > Cc: Eric Van Hensbergen > > Cc: Latchesar Ionkov > > Cc: Dominique Martinet > > Cc: Christian Schoenebeck > > Cc: v9fs@lists.linux.dev > > Signed-off-by: Wedson Almeida Filho > > Reviewed-by: Christian Schoenebeck Looks good to me on principle as well (and it should blow up immediately on testing in the unlikely case there's a problem...) Eric, I don't think you have anything planned for this round? There's another data race patch laying around that we didn't submit for 6.6, shall I take these two for now? (Assuming this patch series is meant to be taken up by individual fs maintainers independantly, it's never really clear with such large swatches of patchs and we weren't in Cc of a cover letter if there was any... In the future it'd help if either there's a clear cover letter everyone is in Cc at (some would say keep everyone in cc of all patches!), or just send these in a loop so they don't appear to be part of a series and each maintainer deals with it as they see fit) -- Dominique