From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B7E5E8FDBC for ; Tue, 3 Oct 2023 21:58:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232437AbjJCV6D (ORCPT ); Tue, 3 Oct 2023 17:58:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232161AbjJCV6C (ORCPT ); Tue, 3 Oct 2023 17:58:02 -0400 Received: from nautica.notk.org (ipv6.notk.org [IPv6:2001:41d0:1:7a93::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0787A1; Tue, 3 Oct 2023 14:57:58 -0700 (PDT) Received: by nautica.notk.org (Postfix, from userid 108) id 65953C01F; Tue, 3 Oct 2023 23:57:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1696370274; bh=VaMPR9vTSeNuv9UUlAuWQrxY0o/yWBumBbUme/UtQSY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r2VlZnQFgPYscwuU/pQZTOyXezD4821oSbFctUhbb4g4ohKxF6x7ztA1Bkw0qHEzJ hdwkfxcPRIBK79hdyHdQeM0EQpTQWX8N/3djGQOoopGQaQ8ObreLFwPRmTRJED9bH5 afcgP1jOjMHPOiE6PlvenYftH6sVhxXuxsSoQH5vrgGfDZYmycc8hGyisVP9MWRC6S XPTOKHIeMMkEW41a70rMjnV5qRXu+sIioFx6phdhBm0IbHApdeqpdHZlkKwFlsjcqq nnYmf8rllBtVv8/UWQp448KZxyePogqqMzr+ne0vXDoHvOE/29J6LtobARGuP8ZHbg zW9zPt3hzuSwA== Received: from gaia (localhost [127.0.0.1]) by nautica.notk.org (Postfix) with ESMTPS id D62F3C009; Tue, 3 Oct 2023 23:57:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1696370272; bh=VaMPR9vTSeNuv9UUlAuWQrxY0o/yWBumBbUme/UtQSY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ntNDqYJUj3LKdZOSYPLAxo7SwyvXz+PePGLQ45IvwZhnt2wpkxYD4aiLjXr4Igvub boDbsOqDr7GeBojwmuO5WOyHVvWQ0i7pgeuw0nJp5JUdW4cTAlCzueDvcVwWcDpJ94 Se6Ra3D1jmd0iTqEe4SkYQivZEkJ/7Qs2fM0zLWh2pMPRkXUWiwk6FizZqZOWZzS27 2xnUy8qhRwbY0CEA8fn0jyB5qRruc0zZ6luV6Zoj9Up48R5Rqh/fb2id46ZzxzBF+3 MLqrrpJzmcS3HANBbUzuylNH1ywKCw0WJy+sq+lGUo5MxaJCzGn6yMCyI7G6d2irxN grsR4aEmfW+OQ== Received: from localhost (gaia [local]) by gaia (OpenSMTPD) with ESMTPA id 3fe28c50; Tue, 3 Oct 2023 21:57:46 +0000 (UTC) Date: Wed, 4 Oct 2023 06:57:31 +0900 From: Dominique Martinet To: Wedson Almeida Filho Cc: Eric Van Hensbergen , Christian Schoenebeck , Alexander Viro , Christian Brauner , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Wedson Almeida Filho , Latchesar Ionkov , v9fs@lists.linux.dev Subject: Re: [PATCH 03/29] 9p: move xattr-related structs to .rodata Message-ID: References: <20230930050033.41174-1-wedsonaf@gmail.com> <20230930050033.41174-4-wedsonaf@gmail.com> <41368837.HejemxxR3G@silver> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Wedson Almeida Filho wrote on Tue, Oct 03, 2023 at 10:55:44AM -0300: > > Looks good to me on principle as well (and it should blow up immediately > > on testing in the unlikely case there's a problem...) > > > > Eric, I don't think you have anything planned for this round? > > There's another data race patch laying around that we didn't submit for > > 6.6, shall I take these two for now? > > > > (Assuming this patch series is meant to be taken up by individual fs > > maintainers independantly, it's never really clear with such large > > swatches of patchs and we weren't in Cc of a cover letter if there was > > any... In the future it'd help if either there's a clear cover letter > > everyone is in Cc at (some would say keep everyone in cc of all > > patches!), or just send these in a loop so they don't appear to be part > > of a series and each maintainer deals with it as they see fit) > > There is a cover letter > (https://lore.kernel.org/all/20230930050033.41174-1-wedsonaf@gmail.com/), > apologies for not CCing you there. I was trying to avoid spamming > maintainers with unrelated changes. > > We need changes in fs/xattr.c (which are in the first patch of the > series) to avoid warnings, so unfortunately this can't be taken > individually. My thought was that individual fs maintainers would > review/ack the patches and this would be taken through the fs tree. Please include all related maintainers in cover letter and any "common" patch: I'd have complained about the warning if I had taken the time to try it out :) (b4 made it easy to download a whole thread, but it was't obvious this was required -- I honestly prefer receiving the whole thread than too little patch but I know some maintainers are split on this... At least I think we'll all agree cover letter and required dependencies are useful though -- I now see David Sterba told you something similar, but only after having written that so leaving it in) By the way the shmem patch failed to apply to 6.6-rc4 and will need rebasing. With all that said, I've taken a few minutes to check it didn't blow up, so: Acked-by: Dominique Martinet -- Dominique Martinet | Asmadeus