From: Christoph Hellwig <hch@infradead.org>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Christian Brauner <brauner@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
Jeff Layton <jlayton@kernel.org>,
Chuck Lever <chuck.lever@oracle.com>,
linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2 3/4] exportfs: define FILEID_INO64_GEN* file handle types
Date: Fri, 27 Oct 2023 00:32:07 -0700 [thread overview]
Message-ID: <ZTtnd6Lis8azPirM@infradead.org> (raw)
In-Reply-To: <CAOQ4uxj_R1KyYJqBXykCDUYZUEdXC3x0j1vZdOXsRcSb6dKaRg@mail.gmail.com>
On Fri, Oct 27, 2023 at 09:43:01AM +0300, Amir Goldstein wrote:
> > Presumable the same for fuse, but for that
> > I'd need to look at how it works for fuse right now and if there's not
> > some subtle differences.
> >
>
> There are subtle differences:
> 1. fuse encodes an internal nodeid - not i_ino
> 2. fuse encodes the inode number as [low32,high32]
>
> It cannot use the generic helper.
That's what I almost feared. It still should use the common symbolic
name for the format just to make everyones life simpler.
next prev parent reply other threads:[~2023-10-27 7:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 18:07 [PATCH v2 0/4] Support more filesystems with FAN_REPORT_FID Amir Goldstein
2023-10-23 18:07 ` [PATCH v2 1/4] exportfs: add helpers to check if filesystem can encode/decode file handles Amir Goldstein
2023-10-27 6:02 ` Christoph Hellwig
2023-10-23 18:07 ` [PATCH v2 2/4] exportfs: make ->encode_fh() a mandatory method for NFS export Amir Goldstein
2023-10-24 15:08 ` Dave Kleikamp
2023-10-27 6:03 ` Christoph Hellwig
2023-10-27 7:09 ` Amir Goldstein
2023-10-27 14:32 ` Amir Goldstein
2023-10-28 14:16 ` Christian Brauner
2023-10-29 9:50 ` Amir Goldstein
2023-10-30 10:26 ` Christian Brauner
2023-10-30 17:18 ` Amir Goldstein
2023-10-23 18:08 ` [PATCH v2 3/4] exportfs: define FILEID_INO64_GEN* file handle types Amir Goldstein
2023-10-27 6:05 ` Christoph Hellwig
2023-10-27 6:43 ` Amir Goldstein
2023-10-27 7:32 ` Christoph Hellwig [this message]
2023-10-27 14:27 ` Amir Goldstein
2023-10-23 18:08 ` [PATCH v2 4/4] exportfs: support encoding non-decodeable file handles by default Amir Goldstein
2023-10-24 11:16 ` [PATCH v2 0/4] Support more filesystems with FAN_REPORT_FID Amir Goldstein
2023-10-24 16:08 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTtnd6Lis8azPirM@infradead.org \
--to=hch@infradead.org \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).