From: Matthew Wilcox <willy@infradead.org>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 3/3] ida: Add kunit based tests for new IDA functions
Date: Thu, 2 Nov 2023 19:12:25 +0000 [thread overview]
Message-ID: <ZUP0mbMqtCaQIQGX@casper.infradead.org> (raw)
In-Reply-To: <e7637a99-ca4f-460a-8ee5-9583790be567@intel.com>
On Thu, Nov 02, 2023 at 07:58:16PM +0100, Michal Wajdeczko wrote:
> On 02.11.2023 18:43, Matthew Wilcox wrote:
> > On Thu, Nov 02, 2023 at 04:34:55PM +0100, Michal Wajdeczko wrote:
> >> New functionality of the IDA (contiguous IDs allocations) requires
> >> some validation coverage. Add KUnit tests for simple scenarios:
> >> - counting single ID at different locations
> >> - counting different sets of IDs
> >> - ID allocation start at requested position
> >> - different contiguous ID allocations are supported
> >>
> >> More advanced tests for subtle corner cases may come later.
> >
> > Why are you using kunit instead of extending the existing test-cases?
>
> I just assumed (maybe wrong) that kunit is preferred these days as some
> other components are even converting their existing test code to kunit.
>
> But also I might be biased as I was working recently with kunit and just
> found it helpful in fast test development. Note that to run these new
> IDA tests, anyone who cares just need a single command line:
>
> $ ./tools/testing/kunit/kunit.py run "ida.*"
>
> But if you feel that having two places with IDA tests is wrong, we can
> still convert old tests to kunit (either as follow up or prerequisite)
> to this patch (well, already did that locally when started working on
> these improvements)
Why would using kunit be superior to the existing test suite?
next prev parent reply other threads:[~2023-11-02 19:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 15:34 [PATCH 0/3] ida: Allow allocations of contiguous IDs Michal Wajdeczko
2023-11-02 15:34 ` [PATCH 1/3] ida: Introduce ida_weight() Michal Wajdeczko
2023-11-02 17:46 ` Matthew Wilcox
2023-11-02 19:05 ` Michal Wajdeczko
2024-01-09 20:52 ` Michal Wajdeczko
2023-11-02 15:34 ` [PATCH 2/3] ida: Introduce ida_alloc_group_range() Michal Wajdeczko
2024-01-09 20:58 ` Michal Wajdeczko
2023-11-02 15:34 ` [PATCH 3/3] ida: Add kunit based tests for new IDA functions Michal Wajdeczko
2023-11-02 17:43 ` Matthew Wilcox
2023-11-02 18:58 ` Michal Wajdeczko
2023-11-02 19:12 ` Matthew Wilcox [this message]
2023-11-02 20:58 ` Michal Wajdeczko
2023-11-02 21:01 ` Matthew Wilcox
2023-11-02 21:33 ` Michal Wajdeczko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUP0mbMqtCaQIQGX@casper.infradead.org \
--to=willy@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).