From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="zY4U6y6l" Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63F91188; Tue, 5 Dec 2023 14:27:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description; bh=E7AglM1sNrEzVXvgP3Pr0r6mYMdRh2+F/SBHIShk58c=; b=zY4U6y6lQoUZxswY4qHKuuGtMg sJixHP0HaCF1NRUNLbKQx1Rts5JMMIgCdPSJbRfX00//4xM6Rse/f/usqrGcuYKcMVvwuLbL61DbH r9U6ocd0dSC2Vwn77w3LWy3ggQ5Dadje/DKxf7gV9zlQQDQU85DTEjlt8pXW0Age0oNooGsLvm0Tl owIo817B6mI00r8rk7Z13PhEpztn1kflJRzQimIIEOrXsFQxN9FBrtW7thGCgsrDmJkrZnIq7FBKa n9UL5MU4XbUSdbAI5KwcRyLsoK/2MT7NP3vE9nJ0EJFBzkiVWUKrHByR86Lo0l2B5wJcnoUGi1poy DJ8rTlUQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rAdse-008Vj3-0o; Tue, 05 Dec 2023 22:27:04 +0000 Date: Tue, 5 Dec 2023 14:27:04 -0800 From: Luis Chamberlain To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Joel Granados , Kees Cook , "Gustavo A. R. Silva" , Iurii Zaikin , Greg Kroah-Hartman , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 00/18] sysctl: constify sysctl ctl_tables Message-ID: References: <20231204-const-sysctl-v2-0-7a5060b11447@weissschuh.net> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: Luis Chamberlain On Tue, Dec 05, 2023 at 06:16:53PM +0100, Thomas Weißschuh wrote: > Hi Luis, Joel, > > On 2023-12-05 09:04:08+0100, Thomas Weißschuh wrote: > > On 2023-12-04 21:50:14-0800, Luis Chamberlain wrote: > > > On Mon, Dec 04, 2023 at 08:52:13AM +0100, Thomas Weißschuh wrote: > > > > Tested by booting and with the sysctl selftests on x86. > > > > > > Can I trouble you to rebase on sysctl-next? > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=sysctl-next > > > > Will do. > > The rebased series is now available at > https://git.sr.ht/~t-8ch/linux b4/const-sysctl I've applied this to sysctl-next as this all looks very sensible to me, except one patch which I'll chime in on, but I'm merging it to sysctl-next now without a promise to get this in as I really would like this to soak in on linux-next for a bit even if it does not get merged in the next kernel release. Exposing it on linux-next will surely iron out run time issues fast. > Nothing much has changed in contrast to v2. > The only functional change so far is the initialization of > ctl_table_header::type in init_header(). > > I'll wait for Joels and maybe some more reviews before resending it. It all is very trivial stuff, except a few patches, but it all is making sense, so my ask is to address feedback this week and post next week a new set so we can have changes merged as-is for Linux in case this really doesn't break anything. For some reason I raccall seeing som hacky sysclts that shared and modified an entry somewhere but the exact sysctl phases me, and I just cannot recall. > > [..] > > For the future I think it would make sense to combine the tree-wide constification > of the structs with the removal of the sentinel values. > > This would reduce the impacts of the maintainers. Indeed. Luis