From: Christoph Hellwig <hch@infradead.org>
To: Christian Brauner <brauner@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>, NeilBrown <neilb@suse.de>,
Al Viro <viro@zeniv.linux.org.uk>,
Oleg Nesterov <oleg@redhat.com>,
Chuck Lever <chuck.lever@oracle.com>,
Jeff Layton <jlayton@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/2] Allow a kthread to declare that it calls task_work_run()
Date: Tue, 5 Dec 2023 21:44:03 -0800 [thread overview]
Message-ID: <ZXAKI76NLlCHGQ7h@infradead.org> (raw)
In-Reply-To: <20231205-altbacken-umbesetzen-e5c0c021ab98@brauner>
On Tue, Dec 05, 2023 at 12:14:29PM +0100, Christian Brauner wrote:
> > For me, the more core of an export it is, the stronger the reason it
> > should be GPL. FWIW, I don't think exporting task_work functionality is
> > a good idea in the first place, but if there's a strong reason to do so,
>
> Yeah, I'm not too fond of that part as well. I don't think we want to
> give modules the ability to mess with task work. This is just asking for
> trouble.
It just seems like a really bad idea. At the same time it fixes a real
problem. If we go a step back how could we fix it in a better way?
Do we even need the task_run based delay for file usage from kernel
threads?
next prev parent reply other threads:[~2023-12-06 5:44 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 1:36 [PATCH 0/2 v2] Move all file-close work for nfsd into nfsd threads NeilBrown
2023-12-04 1:36 ` [PATCH 1/2] Allow a kthread to declare that it calls task_work_run() NeilBrown
2023-12-04 2:13 ` Jens Axboe
2023-12-04 21:02 ` NeilBrown
2023-12-04 22:09 ` Jens Axboe
2023-12-04 22:27 ` NeilBrown
2023-12-05 11:14 ` Christian Brauner
2023-12-05 14:06 ` Jeff Layton
2023-12-05 21:28 ` NeilBrown
2023-12-05 21:58 ` Jens Axboe
2023-12-05 22:03 ` Jens Axboe
2023-12-05 22:16 ` NeilBrown
2023-12-05 23:23 ` NeilBrown
2023-12-05 23:31 ` Jens Axboe
2023-12-06 14:24 ` Christian Brauner
2023-12-08 1:40 ` NeilBrown
2023-12-06 14:29 ` Christian Brauner
2023-12-06 5:44 ` Christoph Hellwig [this message]
2023-12-04 2:25 ` Matthew Wilcox
2023-12-04 21:04 ` NeilBrown
2023-12-04 2:40 ` Al Viro
2023-12-04 16:12 ` Oleg Nesterov
2023-12-04 21:20 ` NeilBrown
2023-12-05 6:27 ` Dave Chinner
2023-12-05 6:41 ` Dave Chinner
2023-12-05 8:48 ` NeilBrown
2023-12-05 11:29 ` Christian Brauner
2023-12-05 11:25 ` Christian Brauner
2023-12-05 14:23 ` Chuck Lever
2023-12-04 1:36 ` [PATCH 2/2] nfsd: Don't leave work of closing files to a work queue NeilBrown
2023-12-04 16:58 ` Chuck Lever
2023-12-04 22:21 ` NeilBrown
2023-12-04 23:48 ` Chuck Lever
2023-12-05 6:36 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXAKI76NLlCHGQ7h@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=neilb@suse.de \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).