From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] freevxfs: Convert vxfs_immed_read_folio to the new folio APIs
Date: Mon, 11 Dec 2023 23:44:33 -0800 [thread overview]
Message-ID: <ZXgPYX3jLfKPZ8Cg@infradead.org> (raw)
In-Reply-To: <ZXHG+/aAiaDvLBxr@casper.infradead.org>
On Thu, Dec 07, 2023 at 01:22:03PM +0000, Matthew Wilcox wrote:
> On Wed, Dec 06, 2023 at 09:24:03PM -0800, Christoph Hellwig wrote:
> > On Wed, Dec 06, 2023 at 08:46:29PM +0000, Matthew Wilcox (Oracle) wrote:
> > > Use folio_fill_tail() and folio_end_read() instead of open-coding them.
> > > Add a sanity check in case a folio is allocated above index 0.
> >
> > Where do these helpers come from? Can't find them in Linus' tree.
>
> Is your tree out of date?
>
> 0b237047d5a7 for folio_end_read()
> $ git describe --contains 0b237047d5a7
> v6.7-rc1~90^2~161
>
> folio_fill_tail() appears to only be in akpm's tree for now. Looks like
> it's still in the 'unstable' part for now, so no sha1 for that.
Heh, I only looked for the first one. But adding what tree you're
sending a patch against not only makes reviewing possible, but also
helps with the destination.
prev parent reply other threads:[~2023-12-12 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 20:46 [PATCH] freevxfs: Convert vxfs_immed_read_folio to the new folio APIs Matthew Wilcox (Oracle)
2023-12-07 5:24 ` Christoph Hellwig
2023-12-07 13:22 ` Matthew Wilcox
2023-12-12 7:44 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXgPYX3jLfKPZ8Cg@infradead.org \
--to=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).