From: Matthew Wilcox <willy@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: bio_vec, bv_page and folios
Date: Tue, 2 Jan 2024 10:24:23 +0000 [thread overview]
Message-ID: <ZZPkV2KU/dHvBB3d@casper.infradead.org> (raw)
In-Reply-To: <5779.1704189838@warthog.procyon.org.uk>
On Tue, Jan 02, 2024 at 10:03:58AM +0000, David Howells wrote:
> Matthew Wilcox <willy@infradead.org> wrote:
>
> > On Tue, Jan 02, 2024 at 08:56:46AM +0000, David Howells wrote:
> > > Hi Christoph, Willy,
> > >
> > > Will bv_page in struct bio_vec ever become a folio pointer rather than I page
> > > pointer? I'm guessing not as it still presumably needs to be able to point to
> > > non-folio pages.
> >
> > My plan for bio_vec is that it becomes phyr -- a physical address +
> > length. No more page or folio reference.
>
> Interesting... What does that mean for those places that currently use
> bv_page as a place to stash a pointer to the page and use it to clean up the
> page later?
I don't intend to get rid of bio_for_each_folio_all() or bio_add_page()
for example. It's just a phys_to_page() away. The advantage is that
we wouldn't need a struct page to do I/O to a physical address.
prev parent reply other threads:[~2024-01-02 10:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-02 8:56 bio_vec, bv_page and folios David Howells
2024-01-02 9:15 ` Matthew Wilcox
2024-01-02 10:03 ` David Howells
2024-01-02 10:24 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZPkV2KU/dHvBB3d@casper.infradead.org \
--to=willy@infradead.org \
--cc=dhowells@redhat.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).