From: Christoph Hellwig <hch@infradead.org>
To: Christian Brauner <brauner@kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
linux-fsdevel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Mateusz Guzik <mjguzik@gmail.com>,
Penglei Jiang <superman.xpt@gmail.com>,
Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
Jeff Layton <jlayton@kernel.org>,
Josef Bacik <josef@toxicpanda.com>,
syzbot+5d8e79d323a13aa0b248@syzkaller.appspotmail.com,
stable@vger.kernel.org, Aishwarya.TCV@arm.com
Subject: Re: [PATCH 1/9] anon_inode: use a proper mode internally
Date: Sun, 13 Apr 2025 22:50:25 -0700 [thread overview]
Message-ID: <Z_yiITQbTzPY28Ig@infradead.org> (raw)
In-Reply-To: <20250411-feigling-mutlos-2a6603ccebb3@brauner>
On Fri, Apr 11, 2025 at 05:03:55PM +0200, Christian Brauner wrote:
> On Fri, Apr 11, 2025 at 11:31:24AM +0100, Mark Brown wrote:
> > On Mon, Apr 07, 2025 at 11:54:15AM +0200, Christian Brauner wrote:
> > > This allows the VFS to not trip over anonymous inodes and we can add
> > > asserts based on the mode into the vfs. When we report it to userspace
> > > we can simply hide the mode to avoid regressions. I've audited all
> > > direct callers of alloc_anon_inode() and only secretmen overrides i_mode
> > > and i_op inode operations but it already uses a regular file.
> >
> > We've been seeing failures in LTP's readadead01 in -next on arm64
> > platforms:
>
> This fscking readhead garbage is driving me insane.
> Ok, readahead skipped anonymous inodes because it's checking whether it
> is a regular file or not. We now make them regular files internally.
> Should be fixed in -next tomorrow.
Is this the readahead syscall? Yeah that random check in the high level
code looks odd if that's what is being triggered here.
next prev parent reply other threads:[~2025-04-14 5:50 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 9:54 [PATCH 0/9] fs: harden anon inodes Christian Brauner
2025-04-07 9:54 ` [PATCH 1/9] anon_inode: use a proper mode internally Christian Brauner
2025-04-07 12:19 ` Jeff Layton
2025-04-07 13:43 ` Christian Brauner
2025-04-07 14:04 ` Jan Kara
2025-04-11 10:31 ` Mark Brown
2025-04-11 15:03 ` Christian Brauner
2025-04-14 5:50 ` Christoph Hellwig [this message]
2025-04-18 2:15 ` Xilin Wu
2025-04-20 10:54 ` Christian Brauner
2025-04-21 8:35 ` Christian Brauner
2025-04-07 9:54 ` [PATCH 2/9] pidfs: use anon_inode_getattr() Christian Brauner
2025-04-07 14:04 ` Jan Kara
2025-04-07 9:54 ` [PATCH 3/9] anon_inode: explicitly block ->setattr() Christian Brauner
2025-04-07 14:05 ` Jan Kara
2025-04-07 9:54 ` [PATCH 4/9] pidfs: use anon_inode_setattr() Christian Brauner
2025-04-07 14:06 ` Jan Kara
2025-04-07 9:54 ` [PATCH 5/9] anon_inode: raise SB_I_NODEV and SB_I_NOEXEC Christian Brauner
2025-04-07 14:07 ` Jan Kara
2025-04-07 14:18 ` Christian Brauner
2025-04-07 9:54 ` [PATCH 6/9] selftests/filesystems: add first test for anonymous inodes Christian Brauner
2025-04-07 14:09 ` Jan Kara
2025-04-07 9:54 ` [PATCH 7/9] selftests/filesystems: add second " Christian Brauner
2025-04-07 14:09 ` Jan Kara
2025-04-07 9:54 ` [PATCH 8/9] selftests/filesystems: add third " Christian Brauner
2025-04-07 14:09 ` Jan Kara
2025-04-07 9:54 ` [PATCH 9/9] selftests/filesystems: add fourth " Christian Brauner
2025-04-07 14:09 ` Jan Kara
2025-04-07 10:19 ` [PATCH 0/9] fs: harden anon inodes Mateusz Guzik
2025-04-07 13:41 ` Christian Brauner
2025-04-07 12:37 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_yiITQbTzPY28Ig@infradead.org \
--to=hch@infradead.org \
--cc=Aishwarya.TCV@arm.com \
--cc=brauner@kernel.org \
--cc=broonie@kernel.org \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mjguzik@gmail.com \
--cc=stable@vger.kernel.org \
--cc=superman.xpt@gmail.com \
--cc=syzbot+5d8e79d323a13aa0b248@syzkaller.appspotmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).