From: Matthew Wilcox <willy@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Tony Solomonik <tony.solomonik@gmail.com>,
Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v8 1/2] Add do_ftruncate that truncates a struct file
Date: Thu, 1 Feb 2024 23:54:29 +0000 [thread overview]
Message-ID: <ZbwvNWJQIQ0W_C9I@casper.infradead.org> (raw)
In-Reply-To: <17b4f4f0-0c33-4c6d-819e-c2e170d4b4b7@kernel.dk>
On Thu, Feb 01, 2024 at 04:20:06PM -0700, Jens Axboe wrote:
> On 1/31/24 2:14 AM, Tony Solomonik wrote:
> > Actually, I'm not quite sure anymore, @Jens Axboe
> > <mailto:axboe@kernel.dk> is there any guarantee in io_uring that the
> > file is always opened as LARGE / 64 bit? From looking at the code, it
> > simply accepts a user made fd, so the user might have not opened it as
> > LARGE on a 32bit system, which might be bad news.
>
> Yeah, we probably want to retain that. Though it'd be a very odd case
> where an application using io_uring isn't opening "large" files by
> default, but we'd still have to ensure that it is.
Oh; my mistake. I thought we required O_LARGEFILE when using io_uring.
next prev parent reply other threads:[~2024-02-01 23:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 8:32 [PATCH v5 0/2] io_uring: add support for ftruncate Tony Solomonik
2024-01-24 8:33 ` [PATCH v5 1/2] Add ftruncate_file that truncates a struct file Tony Solomonik
2024-01-25 17:56 ` Christian Brauner
2024-01-25 18:01 ` Matthew Wilcox
2024-01-24 8:33 ` [PATCH v5 2/2] io_uring: add support for ftruncate Tony Solomonik
2024-01-24 8:52 ` [PATCH v5 0/2] " Cedric Blancher
2024-01-24 12:52 ` Jens Axboe
2024-01-24 13:35 ` Cedric Blancher
2024-01-24 13:42 ` Jens Axboe
2024-01-26 15:21 ` [PATCH v6 " Tony Solomonik
2024-01-26 15:21 ` [PATCH v6 1/2] Add do_ftruncate that truncates a struct file Tony Solomonik
2024-01-26 15:34 ` Matthew Wilcox
2024-01-26 15:21 ` [PATCH v6 2/2] io_uring: add support for ftruncate Tony Solomonik
2024-01-26 15:57 ` [PATCH v7 0/2] " Tony Solomonik
2024-01-26 15:57 ` [PATCH v7 1/2] Add do_ftruncate that truncates a struct file Tony Solomonik
2024-01-28 23:50 ` kernel test robot
2024-01-29 0:50 ` Matthew Wilcox
2024-01-26 15:57 ` [PATCH v7 2/2] io_uring: add support for ftruncate Tony Solomonik
2024-01-29 15:15 ` [PATCH v8 0/2] " Tony Solomonik
2024-01-29 15:15 ` [PATCH v8 1/2] Add do_ftruncate that truncates a struct file Tony Solomonik
2024-01-29 15:32 ` Matthew Wilcox
2024-01-29 15:39 ` Christian Brauner
[not found] ` <CAD62OrETm04q5F7ef8fpB5xF_vTKEHfas5W86QEssZ2ozyg0DQ@mail.gmail.com>
2024-02-01 23:20 ` Jens Axboe
2024-02-01 23:54 ` Matthew Wilcox [this message]
2024-01-29 15:15 ` [PATCH v8 2/2] io_uring: add support for ftruncate Tony Solomonik
2024-02-02 12:17 ` [PATCH v9 0/2] " Tony Solomonik
2024-02-02 12:17 ` [PATCH v9 1/2] Add do_ftruncate that truncates a struct file Tony Solomonik
2024-02-08 15:07 ` Jens Axboe
2024-02-09 10:22 ` Christian Brauner
2024-02-02 12:17 ` [PATCH v9 2/2] io_uring: add support for ftruncate Tony Solomonik
2024-02-09 16:46 ` [PATCH v9 0/2] " Jens Axboe
[not found] ` <CAD62OrGiBX5YuKr_qRzCXPR5Cx_0Vw3Dei9f95Qww1rL45ejdA@mail.gmail.com>
2024-02-09 16:55 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbwvNWJQIQ0W_C9I@casper.infradead.org \
--to=willy@infradead.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tony.solomonik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).