From: Matthew Wilcox <willy@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: Christian Brauner <christian@brauner.io>,
Markus Suvanto <markus.suvanto@gmail.com>,
Marc Dionne <marc.dionne@auristor.com>,
Daniil Dulov <d.dulov@aladdin.ru>,
linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] afs: Fix ignored callbacks over ipv4
Date: Mon, 19 Feb 2024 16:52:57 +0000 [thread overview]
Message-ID: <ZdOHaTLPkV8VlU7x@casper.infradead.org> (raw)
In-Reply-To: <20240219143906.138346-2-dhowells@redhat.com>
On Mon, Feb 19, 2024 at 02:39:02PM +0000, David Howells wrote:
> +++ b/fs/afs/internal.h
> @@ -321,8 +321,7 @@ struct afs_net {
> struct list_head fs_probe_slow; /* List of afs_server to probe at 5m intervals */
> struct hlist_head fs_proc; /* procfs servers list */
>
> - struct hlist_head fs_addresses4; /* afs_server (by lowest IPv4 addr) */
> - struct hlist_head fs_addresses6; /* afs_server (by lowest IPv6 addr) */
> + struct hlist_head fs_addresses; /* afs_server (by lowest IPv6 addr) */
Comment is out of date ...
> @@ -561,8 +560,7 @@ struct afs_server {
> struct afs_server __rcu *uuid_next; /* Next server with same UUID */
> struct afs_server *uuid_prev; /* Previous server with same UUID */
> struct list_head probe_link; /* Link in net->fs_probe_list */
> - struct hlist_node addr4_link; /* Link in net->fs_addresses4 */
> - struct hlist_node addr6_link; /* Link in net->fs_addresses6 */
> + struct hlist_node addr_link; /* Link in net->fs_addresses6 */
Ditto
next prev parent reply other threads:[~2024-02-19 16:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 14:39 [PATCH 0/2] afs: Miscellaneous fixes David Howells
2024-02-19 14:39 ` [PATCH 1/2] afs: Fix ignored callbacks over ipv4 David Howells
2024-02-19 16:52 ` Matthew Wilcox [this message]
2024-02-19 14:39 ` [PATCH 2/2] afs: Increase buffer size in afs_update_volume_status() David Howells
2024-02-19 16:54 ` Matthew Wilcox
2024-02-20 8:51 ` [PATCH 0/2] afs: Miscellaneous fixes Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdOHaTLPkV8VlU7x@casper.infradead.org \
--to=willy@infradead.org \
--cc=christian@brauner.io \
--cc=d.dulov@aladdin.ru \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=markus.suvanto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).