From: Luis Chamberlain <mcgrof@kernel.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Kees Cook <keescook@chromium.org>,
Joel Granados <j.granados@samsung.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 0/4] sysctl: move sysctl type to ctl_table_header
Date: Thu, 22 Feb 2024 08:03:20 -0800 [thread overview]
Message-ID: <ZddwSOaFcr0jUmdA@bombadil.infradead.org> (raw)
In-Reply-To: <20240222-sysctl-empty-dir-v1-0-45ba9a6352e8@weissschuh.net>
On Thu, Feb 22, 2024 at 08:07:35AM +0100, Thomas Weißschuh wrote:
> Praparation series to enable constification of struct ctl_table further
> down the line.
> No functional changes are intended.
>
> These changes have been split out and reworked from my original
> const sysctl patchset [0].
> I'm resubmitting the patchset in smaller chunks for easier review.
> Each split-out series is meant to be useful on its own.
>
> Changes since the original series:
> * Explicit initializartion of header->type in init_header()
> * Some additional cleanups
>
> [0] https://lore.kernel.org/lkml/20231204-const-sysctl-v2-0-7a5060b11447@weissschuh.net/
This all looks super sexy to me, but I'd love Eric's feedback on patch
series before merging as he may know some other facts over sysctl_mount_point
I might be missing.
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Luis
next prev parent reply other threads:[~2024-02-22 16:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 7:07 [PATCH 0/4] sysctl: move sysctl type to ctl_table_header Thomas Weißschuh
2024-02-22 7:07 ` [PATCH 1/4] sysctl: drop sysctl_is_perm_empty_ctl_table Thomas Weißschuh
2024-03-19 15:44 ` Joel Granados
2024-02-22 7:07 ` [PATCH 2/4] sysctl: move sysctl type to ctl_table_header Thomas Weißschuh
2024-03-19 15:43 ` Joel Granados
2024-02-22 7:07 ` [PATCH 3/4] sysctl: drop now unnecessary out-of-bounds check Thomas Weißschuh
2024-03-19 15:27 ` Joel Granados
2024-02-22 7:07 ` [PATCH 4/4] sysctl: remove unnecessary sentinel element Thomas Weißschuh
2024-02-22 16:03 ` Luis Chamberlain [this message]
[not found] ` <CGME20240319154938eucas1p10dd98f7dd53f3e91793bc8d0f34df1ec@eucas1p1.samsung.com>
2024-03-19 15:49 ` [PATCH 0/4] sysctl: move sysctl type to ctl_table_header Joel Granados
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZddwSOaFcr0jUmdA@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=ebiederm@xmission.com \
--cc=j.granados@samsung.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).