From: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Gwendal Grignou <gwendal@chromium.org>,
dlunev@chromium.org
Subject: Re: [PATCH] fat: ignore .. subdir and always add a link to dirs
Date: Fri, 23 Feb 2024 06:58:56 -0300 [thread overview]
Message-ID: <ZdhsYAUCe9GVMnYE@quatroqueijos.cascardo.eti.br> (raw)
In-Reply-To: <87zfvroa1c.fsf@mail.parknet.co.jp>
On Fri, Feb 23, 2024 at 05:32:47PM +0900, OGAWA Hirofumi wrote:
> OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> writes:
>
> > OK.
> >
> > If you want to add the workaround for this, it must emulate the correct
> > format. I.e. sane link count even if without "."/"..". And furthermore
> > it works for any operations.
>
> Of course, it must not affect the correct format. And it should not
> accept the other really corrupted format.
> --
> OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
So far, I have only seen expected correct behavior here: mkdir/rmdir inside the
"bogus" directory works. rmdir of the "bogus" directory works.
The only idiosyncrasies I can think of is that if neither "." or ".." are
present, the directory will have a link of 1, instead of 2. And when listing
the directory, those entries will not show up.
Do you expect any of these to be corrected? It will require a more convoluted
change.
Right now, I think accepting the idiosyncratic behavior for the bogus
filesystems is fine, as long as the correct filesystems continue to behave as
before. Which seems to be the case here as far as my testing has shown.
Thank you.
Cascardo.
next prev parent reply other threads:[~2024-02-23 9:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 20:30 [PATCH] fat: ignore .. subdir and always add a link to dirs Thadeu Lima de Souza Cascardo
2024-02-23 1:52 ` OGAWA Hirofumi
2024-02-23 2:02 ` Thadeu Lima de Souza Cascardo
2024-02-23 8:27 ` OGAWA Hirofumi
2024-02-23 8:32 ` OGAWA Hirofumi
2024-02-23 9:58 ` Thadeu Lima de Souza Cascardo [this message]
2024-02-23 12:29 ` OGAWA Hirofumi
2024-02-23 13:16 ` Thadeu Lima de Souza Cascardo
2024-02-23 13:33 ` Thadeu Lima de Souza Cascardo
2024-02-28 1:42 ` Thadeu Lima de Souza Cascardo
2024-02-28 3:38 ` OGAWA Hirofumi
2024-02-28 9:10 ` Thadeu Lima de Souza Cascardo
2024-03-04 23:37 ` Thadeu Lima de Souza Cascardo
2024-03-05 4:14 ` OGAWA Hirofumi
2024-03-10 5:52 ` OGAWA Hirofumi
2024-03-10 10:14 ` Thadeu Lima de Souza Cascardo
2024-03-10 14:59 ` OGAWA Hirofumi
2024-03-13 7:58 ` Thadeu Lima de Souza Cascardo
2024-03-13 8:05 ` OGAWA Hirofumi
2024-03-13 8:41 ` Thadeu Lima de Souza Cascardo
2024-03-13 11:06 ` OGAWA Hirofumi
2024-03-13 11:16 ` Thadeu Lima de Souza Cascardo
2024-03-13 12:43 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdhsYAUCe9GVMnYE@quatroqueijos.cascardo.eti.br \
--to=cascardo@igalia.com \
--cc=dlunev@chromium.org \
--cc=gwendal@chromium.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).