From: Al Viro <viro@kernel.org>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: linux-kernel@vger.kernel.org, Thomas Graf <tgraf@suug.ch>,
Herbert Xu <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org,
maple-tree@lists.infradead.org, rcu@vger.kernel.org
Subject: Re: [PATCH 1/1] rosebush: Add new data structure
Date: Sun, 25 Feb 2024 01:38:15 -0500 [thread overview]
Message-ID: <ZdrgV8GUE92HMojn@duke.home> (raw)
In-Reply-To: <20240222203726.1101861-2-willy@infradead.org>
On Thu, Feb 22, 2024 at 08:37:24PM +0000, Matthew Wilcox (Oracle) wrote:
> Rosebush is a resizing hash table. See
> Docuemntation/core-api/rosebush.rst for details.
Interesting... A few obvious questions wrt dcache:
* how do the locks that stuff nest wrt ->d_lock? Inside?
* same for rename_lock (on rename dentries change names/parents/hash
values).
* we would be really forced to maintain DCACHE_UNHASHED in ->d_flags;
it's not impossible to do, but will take care (protection of ->d_flags has
several dark corners).
* the cost of d_drop() goes up. Might or might not get painful.
* if the bucket locks nest inside ->d_lock, we'd better look out
for the latter getting held for longer. Might get unpleasant.
next prev parent reply other threads:[~2024-02-25 6:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 20:37 [PATCH 0/1] Rosebush, a new hash table Matthew Wilcox (Oracle)
2024-02-22 20:37 ` [PATCH 1/1] rosebush: Add new data structure Matthew Wilcox (Oracle)
2024-02-25 6:38 ` Al Viro [this message]
2024-02-23 11:37 ` [PATCH 0/1] Rosebush, a new hash table Peng Zhang
2024-02-23 13:55 ` Jason A. Donenfeld
2024-02-23 18:40 ` Kent Overstreet
2024-02-24 0:20 ` Herbert Xu
2024-02-24 22:10 ` David Laight
2024-02-25 0:50 ` Herbert Xu
2024-02-25 3:20 ` Kent Overstreet
2024-02-25 3:18 ` Kent Overstreet
2024-02-25 5:01 ` Matthew Wilcox
2024-02-25 5:32 ` Herbert Xu
2024-02-25 5:51 ` Kent Overstreet
2024-02-25 5:53 ` Herbert Xu
2024-02-25 6:14 ` Kent Overstreet
2024-02-25 6:17 ` Herbert Xu
2024-02-25 14:47 ` David Laight
2024-02-25 21:48 ` Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdrgV8GUE92HMojn@duke.home \
--to=viro@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maple-tree@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=rcu@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).