From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E546F86141 for ; Tue, 5 Mar 2024 13:47:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709646475; cv=none; b=EvNoMG1lD3afKwNJ7MbFoI3hGsLgI7HfNzH0xINDcLJKKSpYMyAbo8n5oCxUMjQ7knxrhFvoYguljWTHa++xHYDQCXmufVUINURRhtuMJSpAQatfgg/+O9rtYJl7Hs+DnvK/aY1AuOnv2gAea2jo14nsV7ekUoLIjOGJeiuBDZU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709646475; c=relaxed/simple; bh=G4REYVf3XLRtxmU4VTSzF5SQLrNKmJZc8qFUh5MbRhA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KM4tzYY1/u62a1MJXHwWLVot/VP6Hk1gk7m6OgW8tiJomMNFBMD1pHWwy+ZgHyTZeQ1v/tCzg2BvugwAVHGTu1S5f8LIaLm9LzR7FIj3acRH+GD0Ue4qf643F9gLJeYrhBaNYPdvduQEb8Azznvaw8HPQ+DIKgzv7fYKZqSs2kg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=qvds27Sp; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="qvds27Sp" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4kpLO4s8L2ervvsS2fuA9MOogE0U0TcIY/XGyl14Aao=; b=qvds27Sppo1/giajShcPFs25Vx GwKHI9G1nMCjc5N5I1kLU3vUi9U71L/r7tFwRheZTvblg2p7ek6gFeTJzNazo6RDF2qYqu8CmYUyx yDtSUrwHxKAekoKJovCQK8mGC4H0QhVblpS1xdiGZuLoufr1xO8W4Yi9lmY1Mdm1oIoF+oUXyRY4T mROZbN+eJWfmKL3eHVm2xZNYTiCQz0LW/2yo/m2W5HAx45Hiif5pLcI4JisFyQBD4qs0k30GZgzjk FF1OXIQ7RfeZJNk8GoIaZm8k1N70tnvgvyrZ0BN5tcsjYV0+SWnXMaTAg9Uq5x6Rxy+B7x4I7tJqU bogK04uA==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhV96-0000000DsyP-2NI7; Tue, 05 Mar 2024 13:47:52 +0000 Date: Tue, 5 Mar 2024 05:47:52 -0800 From: Christoph Hellwig To: Eric Sandeen Cc: linux-fsdevel@vger.kernel.org, Christian Brauner , Christoph Hellwig , Bill O'Donnell , Krzysztof =?utf-8?Q?B=C5=82aszkowski?= Subject: Re: [PATCH] freevxfs: Convert freevxfs to the new mount API. Message-ID: References: Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html > +static int vxfs_init_fs_context(struct fs_context *fc) > +{ > + fc->ops = &vxfs_context_ops; > + > + return 0; Superficial nit, but I would have skipped the empty line here. Otherwise this looks good and thanks for doing the work! Reviewed-by: Christoph Hellwig (and I'm fine with routing all freevxfs patches through Christian)