From: Bill O'Donnell <bodonnel@redhat.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, brauner@kernel.org, sandeen@redhat.com
Subject: Re: [PATCH] minix: convert minix to use the new mount api
Date: Thu, 7 Mar 2024 10:40:39 -0600 [thread overview]
Message-ID: <ZenuBzrEXGseZ_fI@redhat.com> (raw)
In-Reply-To: <20240305212950.GA538574@ZenIV>
On Tue, Mar 05, 2024 at 09:29:50PM +0000, Al Viro wrote:
> On Tue, Mar 05, 2024 at 03:08:18PM -0600, Bill O'Donnell wrote:
> > - if ((bool)(*flags & SB_RDONLY) == sb_rdonly(sb))
> > + if ((bool)(fc->sb_flags & SB_RDONLY) == sb_rdonly(sb))
> > return 0;
>
> This is getting really annoying - let's just add
>
> static inline bool fc_rdonly(const struct fs_context *fc)
> {
> return fc->sb_flags & SB_RDONLY;
> }
>
> and spell the above as
>
> if (fc_rdonly(fc) == sb_rdonly(sb))
> return 0;
>
> etc. Quite a few places have that open-coded...
>
Thanks for your review. I sent a v2, but I'll treat the suggested change
to fs_context_core_code separately.
-Bill
prev parent reply other threads:[~2024-03-07 16:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 21:08 [PATCH] minix: convert minix to use the new mount api Bill O'Donnell
2024-03-05 21:27 ` Eric Sandeen
2024-03-07 16:37 ` Bill O'Donnell
2024-03-05 21:29 ` Al Viro
2024-03-07 16:40 ` Bill O'Donnell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZenuBzrEXGseZ_fI@redhat.com \
--to=bodonnel@redhat.com \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).