From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Zhang Yi <yi.zhang@huaweicloud.com>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, hch@infradead.org,
brauner@kernel.org, david@fromorbit.com, tytso@mit.edu,
jack@suse.cz, yi.zhang@huawei.com, chengzhihao1@huawei.com,
yukuai3@huawei.com
Subject: Re: [PATCH 4/4] iomap: cleanup iomap_write_iter()
Date: Tue, 12 Mar 2024 05:24:00 -0700 [thread overview]
Message-ID: <ZfBJYG5OHgLGewHv@infradead.org> (raw)
In-Reply-To: <20240311160739.GV1927156@frogsfrogsfrogs>
On Mon, Mar 11, 2024 at 09:07:39AM -0700, Darrick J. Wong wrote:
> If at some point iomap_write_end actually starts returning partial write
> completions (e.g. you wrote 250 bytes, but for some reason the pagecache
> only acknowledges 100 bytes were written) then this code no longer
> reverts the iter or truncates posteof pagecache correctly...
I don't think it makes sense to return a partial write from
iomap_write_end. But to make that clear it really should not return
a byte count by a boolean. I've been wanting to make that cleanup
for a while, but it would reach all the way into buffer.c.
next prev parent reply other threads:[~2024-03-12 12:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 12:22 [PATCH 0/4] xfs/iomap: fix non-atomic clone operation and don't update size when zeroing range post eof Zhang Yi
2024-03-11 12:22 ` [PATCH 1/4] xfs: match lock mode in xfs_buffered_write_iomap_begin() Zhang Yi
2024-03-11 15:34 ` Darrick J. Wong
2024-03-12 8:18 ` Zhang Yi
2024-03-12 12:16 ` Christoph Hellwig
2024-03-11 12:22 ` [PATCH 2/4] xfs: convert delayed extents to unwritten when zeroing post eof blocks Zhang Yi
2024-03-11 15:37 ` Darrick J. Wong
2024-03-12 12:21 ` Christoph Hellwig
2024-03-12 12:44 ` Zhang Yi
2024-03-12 12:31 ` Zhang Yi
2024-03-12 16:21 ` Darrick J. Wong
2024-03-13 7:07 ` Zhang Yi
2024-03-13 13:25 ` Zhang Yi
2024-03-13 20:05 ` Darrick J. Wong
2024-03-11 12:22 ` [PATCH 3/4] iomap: don't increase i_size if it's not a write operation Zhang Yi
2024-03-11 15:48 ` Darrick J. Wong
2024-03-12 12:22 ` Christoph Hellwig
2024-03-12 12:59 ` Zhang Yi
2024-03-12 16:24 ` Darrick J. Wong
2024-03-13 7:09 ` Zhang Yi
2024-03-11 12:22 ` [PATCH 4/4] iomap: cleanup iomap_write_iter() Zhang Yi
2024-03-11 16:07 ` Darrick J. Wong
2024-03-12 12:24 ` Christoph Hellwig [this message]
2024-03-12 16:27 ` Darrick J. Wong
2024-03-13 9:23 ` Zhang Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfBJYG5OHgLGewHv@infradead.org \
--to=hch@infradead.org \
--cc=brauner@kernel.org \
--cc=chengzhihao1@huawei.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yi.zhang@huawei.com \
--cc=yi.zhang@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).