From: Cyril Hrubis <chrubis@suse.cz>
To: Christian Brauner <brauner@kernel.org>
Cc: kernel test robot <oliver.sang@intel.com>,
oe-lkp@lists.linux.dev, linux-fsdevel@vger.kernel.org,
lkp@intel.com, ltp@lists.linux.it, linux-kernel@vger.kernel.org
Subject: Re: [LTP] [linus:master] [pidfd] cb12fd8e0d: ltp.readahead01.fail
Date: Fri, 15 Mar 2024 15:49:03 +0100 [thread overview]
Message-ID: <ZfRf36u7CH7bIEZ7@yuki> (raw)
In-Reply-To: <20240315-neufahrzeuge-kennt-317f2a903605@brauner>
Hi!
> So I'd just remove that test. It's meaningless for pseudo fses.
Wouldn't it make more sense to actually return EINVAL instead of
ignoring the request if readahead() is not implemented?
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2024-03-15 14:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 8:16 [linus:master] [pidfd] cb12fd8e0d: ltp.readahead01.fail kernel test robot
2024-03-15 13:42 ` Christian Brauner
2024-03-15 14:49 ` Cyril Hrubis [this message]
2024-03-18 8:47 ` [LTP] " Christian Brauner
2024-04-23 13:52 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfRf36u7CH7bIEZ7@yuki \
--to=chrubis@suse.cz \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=ltp@lists.linux.it \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).