From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0DA18494; Wed, 17 Apr 2024 16:25:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713371146; cv=none; b=AdfmbonS+yKx3yTwy24Z5r1K0T2gsd+MSMYvtVHoMQ8NMC5XQAlnHkfpRwDW/SI2SFTCzOfFVajUA/aFdgYEiqlXo3mbHqYBLmfoP2nTqRkgY+LiRaHQlgKAQAZoI1ZEDkTIRtYzuQMCvCja3G9drZQxKBiidoeDBDd5yRtKDyE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713371146; c=relaxed/simple; bh=Cmxd7/+fzAymlG5WKKxHHTnTQ/RwUCLPsgb+KXnXIHc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=C9WOX+eYBAgiJJbaTfzJpiW/aHN5hFiD1voMqHzbF8b5FdRV0J/lLy4CP5seuCBV9Y7t6YywxsghWr7kgp4V4K8/kwwC0AOh4u9t62AhUhsI+wmTAIQuAvL6JiFqlkYh/tajf9nJgKkyX9qKPchmvnrG/ODmLO8LFiHfGW/NEmM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=jtNNgm+1; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="jtNNgm+1" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FNOr1el/BueGEYH9ReRV1YHomFZKKuDkdYF/EDGjHU8=; b=jtNNgm+1Q1LqYI2cxmrIUJ02KX cuKxf9DRcotpjx6YqaIlJ4fymrsB4qadMxEWhsdlLa5G8wGM7Lo8s0h+QJQrTHxBLnkgyTOG84kP6 yqK9xBICWXAns7Hn/iDzVqnwkiBeh8mJVxI8F8BKoTFnkakyWLTmzaCPps7K+anem0en+YLJDC+0z lZ8iNCaWkNmfjtSIhxEZqggsTfGqA7wsRa83CJLKl/PVAE9icnZR2IUfXu1drhlmmbx+SNJQnz8uB YuemtwEdPZ++E5FwlwFWpQviq+DfouhD3Fc9RsjsMMkeJXevHfbdaix9sGhm1qmhCPBsvx884HXGh b5UD0HHQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx868-00000003HUI-12g8; Wed, 17 Apr 2024 16:25:24 +0000 Date: Wed, 17 Apr 2024 17:25:24 +0100 From: Matthew Wilcox To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , Chris Li , Barry Song , Ryan Roberts , Neil Brown , Minchan Kim , Hugh Dickins , David Hildenbrand , Yosry Ahmed , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Steve French , Namjae Jeon , Paulo Alcantara , Shyam Prasad N , Bharath SM Subject: Re: [PATCH 5/8] cifs: drop usage of page_file_offset Message-ID: References: <20240417160842.76665-1-ryncsn@gmail.com> <20240417160842.76665-6-ryncsn@gmail.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240417160842.76665-6-ryncsn@gmail.com> On Thu, Apr 18, 2024 at 12:08:39AM +0800, Kairui Song wrote: > +++ b/fs/smb/client/file.c > @@ -4749,7 +4749,7 @@ static int cifs_readpage_worker(struct file *file, struct page *page, > static int cifs_read_folio(struct file *file, struct folio *folio) > { > struct page *page = &folio->page; > - loff_t offset = page_file_offset(page); > + loff_t offset = page_offset(page); loff_t offset = folio_pos(folio);